CNDB-15435: Only count live data size in bytes-based paging #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
adelapena
force-pushed
the
CNDB-15435-main-dont-count
branch
from
6cacbf6 to
7fbd8e5
Compare
pkolaczk
approved these changes
Sep 23, 2025
Only count live data size when we are using bytes-sized limits. This prevents issues with paging when row purging or other unexpected transformation changes the size of the read rows. See DBPE-16935 and DBPE-17751.
adelapena
force-pushed
the
CNDB-15435-main-dont-count
branch
from
7fbd8e5 to
0cd4aa4
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2010 rejected by Butler2 regressions found Found 2 new test failures
Found 2 known test failures |
michaelsembwever
pushed a commit
that referenced
this pull request
Sep 25, 2025
…ng (#2010) Only count live data size when we are using bytes-sized limits. This prevents issues with paging when row purging or other unexpected transformation changes the size of the read rows. This fixes DBPE-16935 and DBPE-17751. Rebase notes: * nowInSec and minDeletionTime are not longs instead of ints (ref CASSANDRA-14227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only count live data size when we are using bytes-sized limits. This prevents issues with paging when row purging or other unexpected transformation changes the size of the read rows.