Skip to content

Conversation

mpenick
Copy link
Contributor

@mpenick mpenick commented Mar 1, 2019

A typo in ControlConnection prevents UDT schema metadata from being
properly updated.

A typo in `ControlConnection` prevents UDT schema metadata from being
properly updated.
@mpenick
Copy link
Contributor Author

mpenick commented Mar 1, 2019

Verified the fix using the udt.c example, but this still needs a regression test.

@chakri-stark
Copy link

chakri-stark commented Mar 4, 2019

The test with udt.c will fail if the keyspace do not exists already.
Moving cass_session_get_schema_meta inside insert call is required.


execute_query(session,
"CREATE TABLE examples.udt (id timeuuid, address frozen<address>, PRIMARY KEY(id))");
schema_meta = cass_session_get_schema_meta(session);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope adding this one line will update the schema meta, as it is not required to update for each schema change in this scenario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're correct.

Copy link
Contributor

@mikefero mikefero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpenick mpenick merged commit 4a4b3a6 into master Apr 9, 2019
@mpenick mpenick deleted the CPP-755 branch April 9, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants