Skip to content

CPP-755 UDT schema metadata not properly populated/updated #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2019
Merged

CPP-755 UDT schema metadata not properly populated/updated #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f9c90e
CPP-755 UDT schema metadata not properly populated/updated
mpenick Mar 1, 2019
93faaee
Fix schema meta race in UDT example
mpenick Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/udt/udt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,6 @@ int main(int argc, char* argv[]) {
return -1;
}

schema_meta = cass_session_get_schema_meta(session);

execute_query(session,
"CREATE KEYSPACE examples WITH replication = { \
'class': 'SimpleStrategy', 'replication_factor': '3' }");
Expand All @@ -263,6 +261,8 @@ int main(int argc, char* argv[]) {
execute_query(session,
"CREATE TABLE examples.udt (id timeuuid, address frozen<address>, PRIMARY KEY(id))");

schema_meta = cass_session_get_schema_meta(session);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope adding this one line will update the schema meta, as it is not required to update for each schema change in this scenario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're correct.


insert_into_udt(session);
select_from_udt(session);

Expand Down
2 changes: 1 addition & 1 deletion src/control_connector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ void ControlConnector::handle_query_schema(SchemaConnectorRequestCallback* callb
schema_.views = callback->result("views");
schema_.columns = callback->result("columns");
schema_.indexes = callback->result("indexes");
schema_.user_types = callback->result("types");
schema_.user_types = callback->result("user_types");
schema_.functions = callback->result("functions");
schema_.aggregates = callback->result("aggregates");
schema_.virtual_keyspaces = callback->result("virtual_keyspaces");
Expand Down