Refactor conditional annotation in FileAuditLogFlushScheduler to use … #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ConditionalOnExpression for improved flexibility
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the conditional logic for enabling the FileAuditLogFlushScheduler component by replacing the @ConditionalOnProperty annotation with @ConditionalOnExpression.
- Updated the import and annotation in FileAuditLogFlushScheduler
- Adjusted the conditional expression to check that user.audit.logEvents is true and user.audit.flushOnWrite is not true
| @Component | ||
| @RequiredArgsConstructor | ||
| @ConditionalOnProperty(name = "user.audit.flushOnWrite", havingValue = "false") | ||
| @ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:true}") |
There was a problem hiding this comment.
The default value for user.audit.flushOnWrite is set to true in the expression, which means the scheduler will be disabled unless explicitly overridden. Consider revisiting the default values to ensure they align with the intended enablement behavior from the original configuration.
Suggested change
| @ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:true}") | |
| @ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:false}") |
devondragon
deleted the
issue-182-FileAuditLogFlushScheduler-logs-despite-logEvents-being-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the conditional logic for enabling the
FileAuditLogFlushSchedulercomponent to provide more flexibility in configuration. The most important changes are:Updates to conditional annotations:
@ConditionalOnPropertywith@ConditionalOnExpressioninFileAuditLogFlushSchedulerto allow more complex conditions for enabling the scheduler. The new condition checks thatuser.audit.logEventsis true anduser.audit.flushOnWriteis not true. (src/main/java/com/digitalsanctuary/spring/user/audit/FileAuditLogFlushScheduler.java, [1] [2]