Skip to content

Refactor conditional annotation in FileAuditLogFlushScheduler to use … #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Refactor conditional annotation in FileAuditLogFlushScheduler to use … #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/digitalsanctuary/spring/user/audit/FileAuditLogFlushScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.digitalsanctuary.spring.user.audit;

import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.autoconfigure.condition.ConditionalOnExpression;
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.stereotype.Component;
import lombok.RequiredArgsConstructor;
Expand All @@ -13,7 +13,7 @@
@Slf4j
@Component
@RequiredArgsConstructor
@ConditionalOnProperty(name = "user.audit.flushOnWrite", havingValue = "false")
@ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:true}")
Copy link

Copilot AI May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for user.audit.flushOnWrite is set to true in the expression, which means the scheduler will be disabled unless explicitly overridden. Consider revisiting the default values to ensure they align with the intended enablement behavior from the original configuration.

Suggested change
@ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:true}")
@ConditionalOnExpression("${user.audit.logEvents:true} && !${user.audit.flushOnWrite:false}")

Copilot uses AI. Check for mistakes.
public class FileAuditLogFlushScheduler {

/**
Expand Down