Add new trusted AKV URLs for FR and DE #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 4 new trusted AKV URLs.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for new Azure Key Vault trusted domains by expanding the list of allowed AKV URLs to include French and German sovereign cloud endpoints, as well as US government secure and national cloud endpoints.
Key changes:
- Added 4 new Azure Key Vault domain URLs for different sovereign clouds (USSec, USNat, France Bleu, Germany Delos)
- Added corresponding Managed HSM counterparts for each new domain
- Improved code formatting and organization with better comments and modern C# collection syntax
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Constants.cs
Outdated
Show resolved
Hide resolved
apoorvdeshmukh
previously approved these changes
Jul 16, 2025
priyankatiwari08
previously approved these changes
Jul 16, 2025
- Fixed existing manual tests and added unit tests.
paulmedynski
dismissed stale reviews from priyankatiwari08 and apoorvdeshmukh
via
0c57efd
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3482 +/- ##
==========================================
- Coverage 68.86% 64.58% -4.28%
==========================================
Files 280 271 -9
Lines 62417 61921 -496
==========================================
- Hits 42982 39994 -2988
- Misses 19435 21927 +2492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
approved these changes
Jul 16, 2025
Contributor
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Question about code names, but I'm happy with these
priyankatiwari08
approved these changes
Jul 17, 2025
paulmedynski
added a commit
that referenced
this pull request
Jul 17, 2025
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
paulmedynski
added a commit
that referenced
this pull request
Jul 17, 2025
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
paulmedynski
added a commit
that referenced
this pull request
Jul 17, 2025
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
paulmedynski
added a commit
that referenced
this pull request
Jul 17, 2025
- Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests.
paulmedynski
added a commit
that referenced
this pull request
Jul 18, 2025
* Add new trusted AKV URLs for FR and DE (#3482) - Added 4 new trusted AKV URLs. - Fixed existing manual tests and added unit tests. * - Removed unnecessary strings and console output from TrustedUrlsTest. * - Removed sensitive vault domains.
paulmedynski
added a commit
that referenced
this pull request
Jul 23, 2025
This reverts commit 32abbc7.
paulmedynski
added a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 4 new trusted AKV URLs and their Managed HSM counterparts: