Skip to content

Conversation

@serpent5
Copy link
Contributor

@serpent5 serpent5 commented Jul 8, 2019

Addresses #11978.

My VS Code auto-format also killed a couple of eol whitespaces. If that's not cool, I can put them back.

@analogrelay
Copy link
Contributor

My VS Code auto-format also killed a couple of eol whitespaces. If that's not cool, I can put them back.

In general that's just fine! We just don't want PRs with a huge array of reformatting changes. A couple little auto-format fixups in the files you're already editing is just fine (and appreciated!)

@analogrelay
Copy link
Contributor

@analogrelay
Copy link
Contributor

analogrelay commented Jul 9, 2019

Test/build failures look unrelated, I'll kick the build a little bit :)

@analogrelay analogrelay added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jul 9, 2019
@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build.

@Tratcher Tratcher merged commit 7a1b867 into dotnet:master Jul 10, 2019
@Tratcher Tratcher added this to the 3.0.0-preview8 milestone Jul 10, 2019
@serpent5 serpent5 deleted the serpent5-11978 branch July 10, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants