Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 30, 2023

Backport of #48519 to release/8.0-preview5

/cc @javiercn

[Blazor] Update template to only include inspectUri when using Web assembly

Summary of the changes (Less than 80 chars)

Description

We include the inspectUrl on the template even when webassembly is not enabled, which causes Visual Studio to throw an error when running the app with F5

Fixes #48514

Customer Impact

The customer will see an error in Visual Studio when they try to run the app with F5

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

The change conditionally includes the line in launchSettings.json only when webassembly is specified.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 30, 2023
@mkArtakMSFT mkArtakMSFT added the Servicing-approved Shiproom has approved the issue label May 30, 2023
@ghost
Copy link

ghost commented May 30, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@lewing
Copy link
Member

lewing commented May 30, 2023

For wasm debugging to work we will also need to take dotnet/runtime#86912

@mkArtakMSFT
Copy link
Contributor

@lewing are you sure? @mitchdenny confirmed that removing this from the template (Note: the new Blazor Web App template is what I'm referring to) fixes the issue.

@lewing
Copy link
Member

lewing commented May 30, 2023

@lewing are you sure? @mitchdenny confirmed that removing this from the template (Note: the new Blazor Web App template is what I'm referring to) fixes the issue.

@thaystg can you work with @mitchdenny to verify?

@lewing
Copy link
Member

lewing commented May 30, 2023

My guess is he tested 7.0 but not 8.0 where the runtime problem would surface

@thaystg
Copy link
Member

thaystg commented May 30, 2023

@lewing he is testing NON-WebAssembly App, this is the template that he is using: File | New Project (Blazor Web App)
Not related with WebAssembly debugging.

@javiercn
Copy link
Member

@lewing I don't think this will be a problem. The debug host is not included unless you pass a flag to the template, (UseWebassembly). The issue here is that we weren't including the inspectUrl in the check.

@mkArtakMSFT mkArtakMSFT merged commit adef495 into release/8.0-preview5 May 30, 2023
@mkArtakMSFT mkArtakMSFT deleted the backport/pr-48519-to-release/8.0-preview5 branch May 30, 2023 21:18
@ghost ghost added this to the 8.0-preview5 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants