Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 30, 2023

Backport of #86911 to release/8.0-preview5

/cc @thaystg

The P5 BrowserDebugHost is compiled as part of the runtime build but consumed in aspnetcore at a transport package and previously used the RegexSourceGenerator. Because dotnet/runtime builds with the SDK set by arcade in global.json when BrowserDebugHost was compiled with the Preview4 SDK the and regex source generator used IndexOfAnyValues which no longer exists in the P5 runtime after dotnet/docs#35244 so the proxy fails to bind breakpoints using a P5 runtime.

This stops using the source generator for to regex code to avoid the missing symbol.

Customer Impact

Blazor wasm debugging fails in preview5.

Testing

Manual

Risk

Low, the problem is confined to the debug proxy which does not work at all without this change.

@github-actions github-actions bot requested review from radical and thaystg as code owners May 30, 2023 19:10
@ghost ghost added the area-Debugger-mono label May 30, 2023
@ghost
Copy link

ghost commented May 30, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #86911 to release/8.0-preview5

/cc @thaystg

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@lewing lewing added Servicing-consider Issue for next servicing release review api-ready-for-review API is ready for review, it is NOT ready for implementation labels May 30, 2023
@lewing
Copy link
Member

lewing commented May 30, 2023

The debugger is only tested in runtime so if this is approved you can fast track downstream builds

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 30, 2023
@carlossanlop carlossanlop removed the api-ready-for-review API is ready for review, it is NOT ready for implementation label May 30, 2023
@carlossanlop
Copy link
Contributor

@lewing @radical ping me when this is ready to merge.

@lewing
Copy link
Member

lewing commented May 30, 2023

@carlossanlop It is safe to merge, the linux lane passed and there is nothing windows specific about the change

@thaystg
Copy link
Member

thaystg commented May 30, 2023

@carlossanlop it's ready to be merged. No reasons to wait until windows lane finishes.

@lewing lewing merged commit 90c32f6 into release/8.0-preview5 May 30, 2023
@lewing lewing deleted the backport/pr-86911-to-release/8.0-preview5 branch May 30, 2023 20:51
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants