This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)" #15498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… through four callbacks (dotnet#14982)" This reverts commit c755e3b.
jkotas
approved these changes
Dec 13, 2017
|
@dotnet-bot test Ubuntu16.04 armlb Cross Debug Innerloop Build |
|
Wow... 1 second race condition :)
|
|
Question: How long does it take for a new build to be kicked off, or should I manually start one? I am assuming it is on a 2-4x a day schedule. |
Member
Yes. I do not know how to trigger one manually. |
OK. I have queued up a new build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two associated PRs are causing test instability in CoreFX and are blocking a Maestro update (dotnet/corefx#25872). I'm reverting them here so that I have time to fully investigate the root cause.
I'm currently running the affected CoreFX test suites locally on this change to ensure that the issue is actually fixed by reverting these commits.
cc @ahsonkhan @jkotas @sergiy-k