Half conversion benchmarks #2950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
adamsitnik
approved these changes
Jul 7, 2023
Comment on lines
+10
to
+12
|
|
||
| using BenchmarkDotNet.Attributes; | ||
|
|
There was a problem hiding this comment.
nit: empty lines
Suggested change
| using BenchmarkDotNet.Attributes; | |
| using BenchmarkDotNet.Attributes; |
Comment on lines
+22
to
+31
| BitConverter.UInt16BitsToHalf(0x03ff), //Maximum subnormal number in Half | ||
| (Half)12345.0f /* same value used by other tests to compare the perf */, | ||
| BitConverter.UInt16BitsToHalf(0x7dff) //NaN | ||
| }; | ||
|
|
||
| public static IEnumerable<float> SingleValues => new float[] | ||
| { | ||
| 6.097555E-05f, | ||
| 12345.0f /* same value used by other tests to compare the perf */, | ||
| 65520.0f, //Minimum value that is infinity in Half |
There was a problem hiding this comment.
nit: inconsistent comments
Suggested change
| BitConverter.UInt16BitsToHalf(0x03ff), //Maximum subnormal number in Half | |
| (Half)12345.0f /* same value used by other tests to compare the perf */, | |
| BitConverter.UInt16BitsToHalf(0x7dff) //NaN | |
| }; | |
| public static IEnumerable<float> SingleValues => new float[] | |
| { | |
| 6.097555E-05f, | |
| 12345.0f /* same value used by other tests to compare the perf */, | |
| 65520.0f, //Minimum value that is infinity in Half | |
| BitConverter.UInt16BitsToHalf(0x03ff), // Maximum subnormal number in Half | |
| (Half)12345.0f, // same value used by other tests to compare the perf | |
| BitConverter.UInt16BitsToHalf(0x7dff) // NaN | |
| }; | |
| public static IEnumerable<float> SingleValues => new float[] | |
| { | |
| 6.097555E-05f, | |
| 12345.0f, // same value used by other tests to compare the perf | |
| 65520.0f // Minimum value that is infinity in Half |
|
For some reason I can not apply the suggestions, since they are just style nits I am going to merge the PR right now so we start collecting numbers before merging dotnet/runtime#81632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing performance difference of dotnet/runtime#81632.