-
Notifications
You must be signed in to change notification settings - Fork 285
Half conversion benchmarks #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamsitnik
merged 6 commits into
dotnet:main
from
MineCake147E:half-conversion-benchmarks
Jul 7, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8dcf86
Added benchmarks for conversion between Half and Single
MineCake147E 624caca
Coding convention compliance
MineCake147E fa362bb
Moved benchmarks to Perf.Half.cs
MineCake147E 19eba03
Merge branch 'main' of https://github.com/dotnet/performance into hal…
MineCake147E 365da40
Added simpler Half conversion benchmarks
MineCake147E f1e9404
Removed permuted benchmarks entirely
MineCake147E File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/benchmarks/micro/libraries/System.Runtime/Perf.Half.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,43 @@ | ||||||||||||||||||||||||||||||||||||||||||
| // Licensed to the .NET Foundation under one or more agreements. | ||||||||||||||||||||||||||||||||||||||||||
| // The .NET Foundation licenses this file to you under the MIT license. | ||||||||||||||||||||||||||||||||||||||||||
| // See the LICENSE file in the project root for more information. | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| using System.Collections.Generic; | ||||||||||||||||||||||||||||||||||||||||||
| using System.Globalization; | ||||||||||||||||||||||||||||||||||||||||||
| using System.Linq; | ||||||||||||||||||||||||||||||||||||||||||
| using System.Runtime.CompilerServices; | ||||||||||||||||||||||||||||||||||||||||||
| using System.Runtime.InteropServices; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| using BenchmarkDotNet.Attributes; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| using MicroBenchmarks; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| namespace System.Tests | ||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| [BenchmarkCategory(Categories.Libraries)] | ||||||||||||||||||||||||||||||||||||||||||
| public class Perf_Half | ||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| public static IEnumerable<Half> Values => new Half[] | ||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| BitConverter.UInt16BitsToHalf(0x03ff), //Maximum subnormal number in Half | ||||||||||||||||||||||||||||||||||||||||||
| (Half)12345.0f /* same value used by other tests to compare the perf */, | ||||||||||||||||||||||||||||||||||||||||||
| BitConverter.UInt16BitsToHalf(0x7dff) //NaN | ||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| public static IEnumerable<float> SingleValues => new float[] | ||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||
| 6.097555E-05f, | ||||||||||||||||||||||||||||||||||||||||||
| 12345.0f /* same value used by other tests to compare the perf */, | ||||||||||||||||||||||||||||||||||||||||||
| 65520.0f, //Minimum value that is infinity in Half | ||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+22
to
+31
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: inconsistent comments
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||
| float.NaN | ||||||||||||||||||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| [Benchmark] | ||||||||||||||||||||||||||||||||||||||||||
| [ArgumentsSource(nameof(SingleValues))] | ||||||||||||||||||||||||||||||||||||||||||
| public Half SingleToHalf(float value) => (Half)value; | ||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||
| [Benchmark] | ||||||||||||||||||||||||||||||||||||||||||
| [ArgumentsSource(nameof(Values))] | ||||||||||||||||||||||||||||||||||||||||||
| public float HalfToSingle(Half value) => (float)value; | ||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: empty lines