DependencyInjectionEventSource Memory leak

[windhuan]

.net core 6.0.400-preview.22330.6

my code

Memory analysis

reason , HubConnectionBuilder.Build function

Add instance to DependencyInjectionEventSource._providers when ServiceProvider is created，but it can't remove when serviceprovider has no reference

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

.net core 6.0.400-preview.22330.6

my code

Memory analysis

Add instance to DependencyInjectionEventSource._providers when ServiceProvider is created，but it can't remove when serviceprovider has no reference

Author:	windhuan
Assignees:	-
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[eerhardt]

1. ServiceProvider is IDisposable. You should be disposing it when you are done. I don't see you disposing it above.
2. The reference you show above with DependencyInjectionEventSource is a WeakReference. Which means if there are no other references to the object, the GC is free to clean the object up.

[windhuan]

1. ServiceProvider is IDisposable. You should be disposing it when you are done. I don't see you disposing it above.
2. The reference you show above with DependencyInjectionEventSource is a WeakReference. Which means if there are no other references to the object, the GC is free to clean the object up.

1. i can't get ServiceProvider reference, because HubConnectionBuilder.Build() not return. (HubConnectionBuilder is SignalR client code https://github.com/dotnet/aspnetcore/blob/main/src/SignalR/clients/csharp/Client.Core/src/HubConnectionBuilder.cs)
2. gc can free WeakReference 's object,but it can't free List WeakReference item List<WeakReference<ServiceProvider>> _providers = new();

[eerhardt]

i can't get ServiceProvider reference, because HubConnectionBuilder.Build() not return. (HubConnectionBuilder is SignalR client code

@davidfowl @BrennanConroy - thoughts on Disposing the ServiceProvider in HubConnectionBuilder?

[davidfowl]

The builder doesn't dispose the service provider, when you dispose the HubConnection itself the service provider gets disposed.

[windhuan]

The builder doesn't dispose the service provider, when you dispose the HubConnection itself the service provider gets disposed.

I call the HubConnection.DisposeAsync ,but serviceprovider not disposed

[davidfowl]

Well you build your own service provider (which you aren't supposed to do). This is how you use the HubConnectionBuilder:

var hubConnectionBuilder = new HubConnectionBuilder();
hubConnectionBuilder.WithUrl($"http://{machnie.Address}/signalr/machineHub", (options) =>
{
    options.AccessTokenProvider = () => Task.FromResult(Common.AccessToken.Token);
});
var connection = hubConnectionBuilder.Build();
await connection.DisposeAsync();

[davidfowl]

You can see the code that disposes the connection here https://github.com/dotnet/aspnetcore/blob/7cb457bdaac8de9214391a9b9b273821d01c2300/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs#L558-L570

[windhuan]

You can see the code that disposes the connection here https://github.com/dotnet/aspnetcore/blob/7cb457bdaac8de9214391a9b9b273821d01c2300/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs#L558-L570

HubConnection dispose the child service provider ,but root service provider is not dispose
DependencyInjectionEventSource reference the root service provider