Fix leak caused by not disposing the scoped parent service provider #74261
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsFixes #73832
|
tarekgh
changed the title
|
CC @ericstj |
tarekgh
changed the title
...ies/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs
Show resolved
Hide resolved
...s/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderEngineScopeTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs
Show resolved
Hide resolved
| // If this ServiceProviderEngineScope instance is a root scope, disposing this instance will need to dispose the RootProvider too. | ||
| // Otherwise the RootProvider will never get disposed and will leak. | ||
| // Note, if the RootProvider get disposed first, it will automatically dispose all attached ServiceProviderEngineScope objects. | ||
| RootProvider.Dispose(); |
There was a problem hiding this comment.
Why cant this just noop internally?
There was a problem hiding this comment.
It is simpler. no?
More code, more bugs :-) imagine in the future we add anything to the ServicePrivder dispose method.
There was a problem hiding this comment.
Why cant this just noop internally?
By "just noop internally", you mean adding the if check in ServiceProvider Dispose?
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2905770618 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/2905993688 |
ghost
locked as resolved and limited conversation to collaborators
3 participants
Fixes #73832