Skip to content

[release/8.0-staging] Remove noisy test #102610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [manual] Merge release/8.0-staging into release/8.0
merged 1 commit into from
Jun 5, 2024
Merged

[release/8.0-staging] Remove noisy test #102610

merged 1 commit into from
Jun 5, 2024

Conversation

@ManickaP
Copy link
Member

@ManickaP ManickaP commented May 23, 2024 •
edited by karelz
Loading

Backport of #100640 to release/8.0-staging

Fixes #85331

/cc @carlossanlop @liveans

Customer Impact

Noisy test.

Regression

No

Testing

The same thing is covered by HTTP stress tests, we've removed the test from main as it was causing unnecessary noise.

Risk

LOW, only test code change

@ManickaP
[release/8.0-staging] Remove noisy test
a04f31c 
Backport of #100640 to release/8.0-staging

/cc @carlossanlop @liveans 

## Customer Impact

Noisy test, impacts us.

## Regression

No

## Testing


## Risk

LOW, only test code change
@ghost ghost added the area-System.Net label May 23, 2024
@ManickaP ManickaP requested review from karelz, liveans and rzikm May 23, 2024 14:42
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

CarnaViire
CarnaViire approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we proceed with this one? Test changes are tell-mode :shipit:

@ManickaP ManickaP added the Servicing-consider Issue for next servicing release review label Jun 3, 2024
@karelz karelz added this to the 8.0.x milestone Jun 4, 2024
@karelz
Copy link
Member

karelz commented Jun 4, 2024

I approve. This is test-only change, can we just merge it @carlossanlop or do we need to go through shiproom?

@rzikm
Copy link
Member

rzikm commented Jun 4, 2024

FYI, test-only changes are tell-mode

https://github.com/dotnet/runtime/blob/main/docs/project/library-servicing.md#approval-process (emphasis mine)

If the fix is a test-only or infra-only change, the area owner will:

  • Review the PR and sign-off if they approve it.
  • Add the Servicing-approved label.

@ManickaP ManickaP added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 4, 2024
@carlossanlop
Copy link
Contributor

Tell-mode if test-only. You can merge anytime.

@ManickaP ManickaP merged commit d2f465a into release/8.0-staging Jun 5, 2024
@ManickaP ManickaP deleted the ManickaP-patch-1 branch June 5, 2024 06:53
@karelz karelz mentioned this pull request Jun 24, 2024
Closed
@karelz karelz added the test-bug Problem in test source code (most likely) label Jun 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViire CarnaViire CarnaViire approved these changes

@karelz karelz karelz approved these changes

@liveans liveans liveans approved these changes

@rzikm rzikm Awaiting requested review from rzikm

Assignees

@ManickaP ManickaP

Labels

area-System.Net Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)

Projects

None yet

Milestone

8.0.x

Development

Successfully merging this pull request may close these issues.

6 participants

@ManickaP @karelz @rzikm @carlossanlop @CarnaViire @liveans