Enable TryFormat_MatchesToString for HybridGlobalization
#104026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
ilonatommy
changed the title
for HybridGlobalization`TryFormat_MatchesToString for HybridGlobalization
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 26, 2024
Open
|
We are not running NodeJS on Windows on CI. |
mkhamoyan
approved these changes
Jun 27, 2024
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
reviewed
Jun 27, 2024
pavelsavara
approved these changes
Jun 27, 2024
|
/ba-g |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95623. I cannot reproduce locally.
This PR fixes NodeJS Windows runs, they were not triggered by extra platforms. It also removes a duplicated run of libraries on Windows with Chrome host - it was both in extra platforms and in runtime.