Skip to content

Enable TryFormat_MatchesToString for HybridGlobalization #104026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Enable TryFormat_MatchesToString for HybridGlobalization #104026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7b0c20
Enable `TryFormat_MatchesToString`
ilonatommy Jun 26, 2024
8cfd471
Fix: Windows NodeJS should run on extra platforms
ilonatommy Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,18 @@ jobs:
scenarios:
- WasmTestOnNodeJS

# Library tests - Windows
# Library tests - Windows - this only runs on the extra pipeline
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
parameters:
platforms:
- browser_wasm_win
nameSuffix: _NodeJs
extraBuildArgs: /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
# Don't run for rolling builds, as this is covered
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
scenarios:
- WasmTestOnChrome
- WasmTestOnNodeJS

# EAT Library tests - only run on linux
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2734,7 +2734,6 @@ internal struct SYSTEMTIME

[Theory]
[MemberData(nameof(StandardFormatSpecifiers))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/95623", typeof(PlatformDetection), nameof(PlatformDetection.IsHybridGlobalizationOnBrowser))]
public static void TryFormat_MatchesToString(string format)
{
DateTime dt = DateTime.UtcNow;
Expand Down