Skip to content

System.Runtime.Serialization.Formatters: fix target framework check for source-build. #104735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024
Merged

System.Runtime.Serialization.Formatters: fix target framework check for source-build. #104735

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32c7db3
System.Runtime.Serialization.Formatters: fix target framework check f…
tmds Jul 11, 2024
6fb916f
Don't build the net8.0 target when DotNetBuildSourceOnly.
tmds Jul 11, 2024
41388fe
Join lines.
tmds Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ystem.Runtime.Serialization.Formatters/src/System.Runtime.Serialization.Formatters.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PropertyGroup>
<NoWarn>$(NoWarn);CA1822;IDE0060</NoWarn>

<FunctioningBinaryFormatter Condition="'$(TargetFramework)' == '$(NetCoreAppMinimum)'">true</FunctioningBinaryFormatter>
<FunctioningBinaryFormatter Condition="'$(TargetFramework)' == '$(NetCoreAppMinimum)' and '$(DotNetBuildSourceOnly)' != 'true'">true</FunctioningBinaryFormatter>
<!-- The GenerateNuspec target fails if this property is keyed off of FunctioningBinaryFormatter, so keep it logically in sync -->
<IncludeBuildOutput Condition="'$(TargetFramework)' == '$(NetCoreAppCurrent)'">false</IncludeBuildOutput>
<SuppressDependenciesWhenPacking Condition="'$(FunctioningBinaryFormatter)' != 'true'">true</SuppressDependenciesWhenPacking>
Expand Down