SLH-DSA implementation for OpenSSL #114060

PranavSenthilnathan · 2025-03-31T06:20:59Z

Adds the OpenSSL implementation for SLH-DSA. This mostly uses ML-DSA and ML-KEM as a reference and consolidates common APIs where applicable.

Fixes #114665

Add back APIs depending on PbeParameters for netstandard2.0 Add OpenSsl SafeHandle API Update tests

ghost · 2025-03-31T06:21:07Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2025-03-31T06:21:08Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2025-03-31T06:21:39Z

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot

Pull Request Overview

This PR introduces the OpenSSL implementation for SLH-DSA by consolidating common APIs and aligning test infrastructure with the new changes.
Key changes include:
- Replacing explicit OpenSSL version checks with a new boolean property (IsOpenSsl3_5) in test code.
- Refactoring SLH-DSA test infrastructure by replacing “TestImplementation” with “MockImplementation” and adding abstract methods to standardize key-generation and import/export APIs.
- Updating test vectors and adjusting interop/dynamic linking files; documentation updates reflect native build target path changes.

Reviewed Changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 3 comments.

File	Description
src/libraries/Common/tests/System/Security/Cryptography/MLKemImplementationTests.cs	Simplifies platform check using IsOpenSsl3_5.
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestsBase.cs	Adds abstract methods for key generation and import/export in test base.
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaMockImplementation.cs	Renames test implementation class for clarity.
docs/workflow/building/libraries/README.md	Updates build command documentation for native libraries.

Comments suppressed due to low confidence (1)

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaMockImplementation.cs:11

Renaming from 'SlhDsaTestImplementation' to 'SlhDsaMockImplementation' improves clarity; ensure that related documentation and comments are updated accordingly.

internal sealed class SlhDsaMockImplementation : SlhDsa

src/libraries/Common/tests/System/Security/Cryptography/MLKemImplementationTests.cs

...Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestsBase.cs

docs/workflow/building/libraries/README.md

...raries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EvpPKey.SlhDsa.cs

.../Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestData.cs

src/libraries/System.Security.Cryptography/src/Resources/Strings.resx

...ystem.Security.Cryptography/src/System/Security/Cryptography/SlhDsaImplementation.OpenSsl.cs

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey.c

vcsjones · 2025-04-02T01:15:58Z

@PranavSenthilnathan The build is failing here because Linux is a case-sensitive file system and your csproj file and the file name differ by case

Interop.EvpPkey.SlhDsa.cs vs Interop.EvpPKey.SlhDsa.cs (The k vs K)

...ystem/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaImplementationTestsBase.cs

src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.NotSupported.cs

src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.Unix.cs

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c

...on/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaPlatformTests.cs

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c

krwq · 2025-04-16T07:32:37Z

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c

+
+    if (context)
+    {
+        contextParams[0] = OSSL_PARAM_construct_octet_string(OSSL_SIGNATURE_PARAM_CONTEXT_STRING, (void*)context, Int32ToSizeT(contextLen));


I think this entire method is identical to ML-DSA minus one assert, we might want to consider unifying the core part (and same for sign)

I did that in a previous iteration but Jeremy suggested duplicating instead: #114060 (comment)

I'm open to squeezing it down to shared things, but as a followup. Naming and shaping being the hard parts, of course 😄. The earlier attempt didn't feel right, and just having an entirely separate function felt/feels like the best short term answer, rather than ratholing on the shape and blocking other progress.

PranavSenthilnathan · 2025-04-16T17:15:49Z

@vcsjones Could you please run the OpenSSL 3.5 CI?

@vcsjones-bot test 82c847d with openssl-3.5

vcsjones · 2025-04-16T18:25:10Z

@vcsjones Could you please run the OpenSSL 3.5 CI?

https://github.com/vcsjones/runtime-ci/actions/runs/14499783145

@bartonjs also has the power to do this.

The bot still doesn't allow anyone other than me (the trouble with the bot is it does other things than .NET Runtime related tasks and I need to figure out a good auth model for the whole thing).

bartonjs · 2025-04-17T16:17:38Z

...s/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestsBase.cs

+            byte[] signature = new byte[mldsa.Algorithm.SignatureSizeInBytes];
+            Assert.Equal(signature.Length, mldsa.SignData([], signature));
+
+            ExerciseSuccessfulVerify(mldsa, [], signature, []);


[] and ReadOnlySpan.Default sometimes P/Invoke differently. We probably want a specific test for the span-based methods that ensure that ReadOnlySpan.Default works. That can be done as a followup.

Instead of a different test, the helper routine could check if length == 0 and then try both the [] and the Empty versions.

...Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestsBase.cs

…thmImplementations/SlhDsa/SlhDsaTestsBase.cs Co-authored-by: Jeremy Barton <[email protected]>

PranavSenthilnathan · 2025-04-18T04:12:40Z

/ba-g test failures so far look unrelated and the test run before the merge was also the same

SLH-DSA implementation for OpenSSL

1d5593e

Add back APIs depending on PbeParameters for netstandard2.0 Add OpenSsl SafeHandle API Update tests

PranavSenthilnathan added the area-System.Security label Mar 31, 2025

ghost added the new-api-needs-documentation label Mar 31, 2025

dotnet-policy-service bot assigned PranavSenthilnathan Mar 31, 2025

PranavSenthilnathan requested a review from Copilot March 31, 2025 06:24

Copilot AI reviewed Mar 31, 2025

View reviewed changes

krwq reviewed Mar 31, 2025

View reviewed changes

...raries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.EvpPKey.SlhDsa.cs Show resolved Hide resolved

This was referenced Mar 31, 2025

[wasm][AOT][net8.0] emcc : error - received SIGKILL (-9) #89402

Open

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Closed

bartonjs reviewed Mar 31, 2025

View reviewed changes

PranavSenthilnathan added 3 commits April 9, 2025 23:03

PR comments

ced5261

merge

cfcd249

merge cleanup

5499e18

This was referenced Apr 10, 2025

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts #114241

Closed

SIGKILL System.Runtime.Serialization.Formatters.Tests #114287

Open

PranavSenthilnathan added 2 commits April 10, 2025 23:07

Add nist tests and copy over ml-dsa tests

83fabda

add platform check condition to tests

5a8ccc0

build-analysis bot mentioned this pull request Apr 11, 2025

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

PranavSenthilnathan marked this pull request as ready for review April 11, 2025 21:26

bartonjs reviewed Apr 14, 2025

View reviewed changes

...ystem/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaImplementationTestsBase.cs Show resolved Hide resolved

bartonjs reviewed Apr 14, 2025

View reviewed changes

src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.NotSupported.cs Show resolved Hide resolved

bartonjs reviewed Apr 14, 2025

View reviewed changes

src/libraries/System.Security.Cryptography/tests/SlhDsaOpenSslConstructionTests.Unix.cs Show resolved Hide resolved

vcsjones reviewed Apr 15, 2025

View reviewed changes

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c Outdated Show resolved Hide resolved

PranavSenthilnathan added 3 commits April 15, 2025 13:46

merge

5947ef6

fix merge

5a5f38c

PR feedback, incorporate changes from ml-dsa

927d8a5

krwq reviewed Apr 16, 2025

View reviewed changes

...on/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaPlatformTests.cs Outdated Show resolved Hide resolved

krwq reviewed Apr 16, 2025

View reviewed changes

src/native/libs/System.Security.Cryptography.Native/pal_evp_pkey_slh_dsa.c Outdated Show resolved Hide resolved

krwq reviewed Apr 16, 2025

View reviewed changes

PR feedback

82c847d

This was referenced Apr 16, 2025

System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319

Closed

OSX failure on StringTests.StartsWithNoMatch_StringComparison #112195

Open

Tracking: Failed to find a suitable device for target tvos-device dotnet/dnceng#5179

Open

bartonjs reviewed Apr 17, 2025

View reviewed changes

...Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaTestsBase.cs Show resolved Hide resolved

bartonjs approved these changes Apr 17, 2025

View reviewed changes

PranavSenthilnathan and others added 2 commits April 17, 2025 09:45

Update src/libraries/Common/tests/System/Security/Cryptography/Algori…

e547a15

…thmImplementations/SlhDsa/SlhDsaTestsBase.cs Co-authored-by: Jeremy Barton <[email protected]>

Make sure empty spans work as expected

b880aa6

This was referenced Apr 17, 2025

Exclude System.IO.Compression async tests from wasm #114769

Closed

Failures in System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandlerTest.GetAsync_ManyDifferentResponseHeaders_ParsedCorrectly #114790

Closed

merge

45f02b7

PranavSenthilnathan merged commit 15bcd62 into dotnet:main Apr 18, 2025
87 of 99 checks passed

github-actions bot locked and limited conversation to collaborators May 18, 2025

SLH-DSA implementation for OpenSSL #114060

SLH-DSA implementation for OpenSSL #114060

Conversation

PranavSenthilnathan commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 31, 2025

Uh oh!

ghost commented Mar 31, 2025

Uh oh!

dotnet-policy-service bot commented Mar 31, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vcsjones commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krwq Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PranavSenthilnathan Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

bartonjs Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

PranavSenthilnathan commented Apr 16, 2025

Uh oh!

vcsjones commented Apr 16, 2025

Uh oh!

bartonjs Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

bartonjs Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PranavSenthilnathan commented Apr 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PranavSenthilnathan commented Mar 31, 2025 •

edited

Loading

krwq Apr 16, 2025 •

edited

Loading