Clear contained flag from AND->NOT transformation #117801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the JIT compiler's constant comparison optimization by clearing the contained flag when transforming AND operations into NOT operations. The issue occurs during the lowering phase when optimizing comparisons like EQ|NE(AND(x, y), y) into EQ|NE(AND(NOT(x), y), 0).
- Adds a call to
ClearContained()before creating the NOT node to prevent incorrect code generation - Fixes three reported issues related to improper handling of contained flags during tree transformations
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Jul 18, 2025
|
/ba-g "Segmentation fault in clang on osx-x64 Debug CoreCLR_Libraries" |
khushal1996
pushed a commit
to khushal1996/runtime
that referenced
this pull request
Jul 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117795
Fixes #117783
Fixes #116657
Fixes #116674
Introduced in #111933
We had
AND(X, CNS)where we marked X as contained. Then this transformation convertedAND(X, CNS)intoNOT(X)whileXis still marked as contained when the emitter doesn't support containment for this node.