-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/10.0] Implement UnhandledException hook for finalizer scenario in Mono. #118878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/10.0] Implement UnhandledException hook for finalizer scenario in Mono. #118878
Conversation
|
CC: @mangod9 |
|
The failure with LLVMFULLAOT is #112557 |
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 10 rc1
639ab88 to
8757fe7
Compare
|
blocking merge to investigate possible issue (#118981) |
That was because couple tests were not supposed to run with |
3b637f0 to
6bd4976
Compare
|
marking approved since @jeffschwMSFT approved |
6bd4976 to
1856d3d
Compare
|
The failure does not seem to be related to finalizers. |
…fullaot` (#119039) These kind of tests are not compatible.
1856d3d to
1ed52da
Compare
|
The errors are the same as without this change (ex: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1134198&view=ms.vss-test-web.build-test-results-tab) I think we can merge this. |
|
I do not have permissions to merge though . . . |
|
@jeffschwMSFT should be able to merge. |
|
Thanks! |
Backport of #118563 to release/10.0
/cc @VSadov
Customer Impact
A Mono counterpart to a new feature already implemented in CoreCLR and NativeAOT. Missed RC snap.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Same tests as used for CoreCLR/NativeAOT are enabled in this change for Mono.
Risk
This is a new feature. Just the Mono part of it missed RC snap.