Disable UnhandledExceptionHandler tests with native components on llvmfullaot
#119039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fullaot` These kind of tests are not compatible.
VSadov
added
the
disabled-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables UnhandledExceptionHandler tests with native components on llvmfullaot runtime to address compatibility issues. The tests involve loading native libraries that interact with the runtime in ways that cause problems with LLVM full AOT compilation.
- Adds exclusion rules for UnhandledExceptionHandler tests in Foreign and PInvoke subdirectories
- Follows existing pattern used for similar tests that have native component interactions
3 tasks
steveisok
approved these changes
Aug 24, 2025
Member
Author
|
Thanks!! |
VSadov
added a commit
that referenced
this pull request
Aug 25, 2025
…fullaot` (#119039) These kind of tests are not compatible.
VSadov
added a commit
that referenced
this pull request
Aug 26, 2025
…fullaot` (#119039) These kind of tests are not compatible.
VSadov
added a commit
that referenced
this pull request
Aug 28, 2025
…fullaot` (#119039) These kind of tests are not compatible.
VSadov
added a commit
that referenced
this pull request
Aug 28, 2025
…fullaot` (#119039) These kind of tests are not compatible.
jeffschwMSFT
pushed a commit
that referenced
this pull request
Aug 29, 2025
…io in Mono. (#118878) * Implement UnhandledException hook for finalizers in Mono. * Cache the finalize method on wasm * Precompile invoke helper for GuardedFinalize * only check for GuardedFinalize in corlib * make GuardedFinalize virtual * use mono_runtime_try_invoke, since we can wih instance methods * comment out unused * Move GuardedFinalize to a helper class * make it static * some cleanup * remove no longer relevant comment * Disable UnhandledExceptionHandler tests with foreign threads on `llvmfullaot` (#119039) These kind of tests are not compatible. --------- Co-authored-by: vsadov <[email protected]> Co-authored-by: Vladimir Sadov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #118981
These tests load a native .dll/.so , which starts threads, enters the runtime, runs managed code, throws unhandled exceptions...
We have other similar tests. They are marked as incompatible with
llvmfullaot.I guess, these should be marked incompatible as well.