Skip to content

[wasm] Mark System.Diagnostics.XmlWriterTraceListener APIs as unsupported on Browser #41327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[wasm] Mark System.Diagnostics.XmlWriterTraceListener APIs as unsupported on Browser #41327

wants to merge 2 commits into from

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 25, 2020

Contributes to #41087

browser "M:System.Diagnostics.XmlWriterTraceListener.TraceData(System.Diagnostics.TraceEventCache,System.String,System.Diagnostics.TraceEventType,System.Int32,System.Object)",System.Diagnostics,XmlWriterTraceListener,"TraceData(TraceEventCache, String, TraceEventType, Int32, Object)",3
browser "M:System.Diagnostics.XmlWriterTraceListener.TraceEvent(System.Diagnostics.TraceEventCache,System.String,System.Diagnostics.TraceEventType,System.Int32,System.String,System.Object[])",System.Diagnostics,XmlWriterTraceListener,"TraceEvent(TraceEventCache, String, TraceEventType, Int32, String, Object[])",3
browser "M:System.Diagnostics.XmlWriterTraceListener.TraceData(System.Diagnostics.TraceEventCache,System.String,System.Diagnostics.TraceEventType,System.Int32,System.Object[])",System.Diagnostics,XmlWriterTraceListener,"TraceData(TraceEventCache, String, TraceEventType, Int32, Object[])",3
browser "M:System.Diagnostics.XmlWriterTraceListener.TraceEvent(System.Diagnostics.TraceEventCache,System.String,System.Diagnostics.TraceEventType,System.Int32,System.String)",System.Diagnostics,XmlWriterTraceListener,"TraceEvent(TraceEventCache, String, TraceEventType, Int32, String)",3
browser "M:System.Diagnostics.XmlWriterTraceListener.TraceTransfer(System.Diagnostics.TraceEventCache,System.String,System.Int32,System.String,System.Guid)",System.Diagnostics,XmlWriterTraceListener,"TraceTransfer(TraceEventCache, String, Int32, String, Guid)",3

@ghost
Copy link

ghost commented Aug 25, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@MaximLipnin MaximLipnin mentioned this pull request Aug 25, 2020
Closed
71 tasks
@akoeplinger
Copy link
Member

akoeplinger commented Aug 28, 2020

Hm this looks like another false-positive case. We have a test that verifies TraceData works here and it seems to be running on Browser: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs#L252

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 31, 2020

Closing this PR as these changes are not needed.

@mdh1418 mdh1418 closed this Aug 31, 2020
@mdh1418 mdh1418 deleted the mdhwang/system_diagnostics_twtl_unsupported branch August 31, 2020 13:20
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@MaximLipnin MaximLipnin Awaiting requested review from MaximLipnin

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.Diagnostics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdh1418 @akoeplinger @danmoseley