Skip to content

[wasm] Mark System.Diagnostics.XmlWriterTraceListener APIs as unsupported on Browser #41327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[wasm] Mark System.Diagnostics.XmlWriterTraceListener APIs as unsupported on Browser #41327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d31f14
[wasm] System.Diagnostics.TextWriterTraceListener enable platform att…
Aug 25, 2020
04157dc
[wasm] Mark System.Diagnostics.XmlWriterTraceListener APIs as unsuppo…
Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Diagnostics.TextWriterTraceListener/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
<Import Project="..\Directory.Build.props" />
<PropertyGroup>
<StrongNameKeyId>Microsoft</StrongNameKeyId>
<IncludePlatformAttributes>true</IncludePlatformAttributes>
</PropertyGroup>
</Project>
5 changes: 5 additions & 0 deletions ...tem.Diagnostics.TextWriterTraceListener/ref/System.Diagnostics.TextWriterTraceListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,15 @@ public XmlWriterTraceListener(string? filename) { }
public XmlWriterTraceListener(string? filename, string? name) { }
public override void Close() { }
public override void Fail(string? message, string? detailMessage) { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public override void TraceData(System.Diagnostics.TraceEventCache? eventCache, string source, System.Diagnostics.TraceEventType eventType, int id, object? data) { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public override void TraceData(System.Diagnostics.TraceEventCache? eventCache, string source, System.Diagnostics.TraceEventType eventType, int id, params object?[]? data) { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public override void TraceEvent(System.Diagnostics.TraceEventCache? eventCache, string source, System.Diagnostics.TraceEventType eventType, int id, string? message) { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public override void TraceEvent(System.Diagnostics.TraceEventCache? eventCache, string source, System.Diagnostics.TraceEventType eventType, int id, string format, params object?[]? args) { }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public override void TraceTransfer(System.Diagnostics.TraceEventCache? eventCache, string source, int id, string? message, System.Guid relatedActivityId) { }
public override void Write(string? message) { }
public override void WriteLine(string? message) { }
Expand Down
5 changes: 5 additions & 0 deletions ...stem.Diagnostics.TextWriterTraceListener/src/System/Diagnostics/XmlWriterTraceListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public override void Fail(string? message, string? detailMessage)
}));
}

[UnsupportedOSPlatform("browser")]
public override void TraceEvent(TraceEventCache? eventCache, string source, TraceEventType eventType, int id, string format, params object?[]? args)
{
if (Filter != null && !Filter.ShouldTrace(eventCache, source, eventType, id, format, args, null, null))
Expand All @@ -94,6 +95,7 @@ public override void TraceEvent(TraceEventCache? eventCache, string source, Trac
WriteFooter(eventCache);
}

[UnsupportedOSPlatform("browser")]
public override void TraceEvent(TraceEventCache? eventCache, string source, TraceEventType eventType, int id, string? message)
{
if (Filter != null && !Filter.ShouldTrace(eventCache, source, eventType, id, message, null, null, null))
Expand All @@ -104,6 +106,7 @@ public override void TraceEvent(TraceEventCache? eventCache, string source, Trac
WriteFooter(eventCache);
}

[UnsupportedOSPlatform("browser")]
public override void TraceData(TraceEventCache? eventCache, string source, TraceEventType eventType, int id, object? data)
{
if (Filter != null && !Filter.ShouldTrace(eventCache, source, eventType, id, null, null, data, null))
Expand All @@ -123,6 +126,7 @@ public override void TraceData(TraceEventCache? eventCache, string source, Trace
WriteFooter(eventCache);
}

[UnsupportedOSPlatform("browser")]
public override void TraceData(TraceEventCache? eventCache, string source, TraceEventType eventType, int id, params object?[]? data)
{
if (Filter != null && !Filter.ShouldTrace(eventCache, source, eventType, id, null, null, null, data))
Expand Down Expand Up @@ -186,6 +190,7 @@ public override void Close()
_strBldr = null;
}

[UnsupportedOSPlatform("browser")]
public override void TraceTransfer(TraceEventCache? eventCache, string source, int id, string? message, Guid relatedActivityId)
{
if (Filter != null && !Filter.ShouldTrace(eventCache, source, TraceEventType.Transfer, id, message, null, null, null))
Expand Down