Optimise GetCustomAttributes - Part 1 #53152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkotas
commented
May 24, 2021
jkotas
commented
- Use is/is not instead of ==/!=. Avoids overhead from operator overloading
- Pass ListBuilder as ref instead of out. Avoids redundant initialization to default.
- Use HashSet instead of Dictionary.
- Use is/is not instead of ==/!=. Avoids overhead from operator overloading - Pass ListBuilder as ref instead of out. Avoids redundant initialization to default. - Use HashSet instead of Dictionary.
stephentoub
approved these changes
May 24, 2021
Member
Does this end up making a measurable difference? |
Member
Author
This PR is a subset of changes peeled off from #45121. I do not think any one of changes make a huge difference, just saving a few instructions here or there, but it adds up in aggregate. |
Member
Author
|
The failure is infrastructure issue: azure.devops.exceptions.AzureDevOpsClientRequestError: Operation returned an invalid status code of 503. |
jeffhandley
reviewed
May 24, 2021
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks for doing this, @jkotas!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.