Override the APM methods on AsyncWindowsFileStreamStrategy. #55203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io |
stephentoub
reviewed
Jul 9, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/AsyncWindowsFileStreamStrategy.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 9, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/AsyncWindowsFileStreamStrategy.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 9, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/AsyncWindowsFileStreamStrategy.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jul 9, 2021
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than my comments, LGTM. Thanks.
Contributor
Author
|
OK, feedback is addressed. |
stephentoub
reviewed
Jul 14, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/AsyncWindowsFileStreamStrategy.cs
Outdated
Show resolved
Hide resolved
…AsyncWindowsFileStreamStrategy.cs
stephentoub
approved these changes
Jul 14, 2021
Member
|
Thanks! |
|
This was a pretty severe bug. I just had an idea on how this could be avoided in the future: Write a reflection-based test that makes sure that all |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55172.