Skip to content

Override the APM methods on AsyncWindowsFileStreamStrategy. #55203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Override the APM methods on AsyncWindowsFileStreamStrategy. #55203

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26d87c2
Override the APM methods on AsyncWindowsFileStreamStrategy.
teo-tsirpanis Jul 6, 2021
c7f43a3
Address PR feedback.
teo-tsirpanis Jul 10, 2021
014bcfa
Update src/libraries/System.Private.CoreLib/src/System/IO/Strategies/…
stephentoub Jul 14, 2021
7373191
Update AsyncWindowsFileStreamStrategy.cs
stephentoub Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...braries/System.Private.CoreLib/src/System/IO/Strategies/AsyncWindowsFileStreamStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public override Task<int> ReadAsync(byte[] buffer, int offset, int count, Cancel
public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
=> ReadAsyncInternal(destination, cancellationToken);

private unsafe ValueTask<int> ReadAsyncInternal(Memory<byte> destination, CancellationToken cancellationToken = default)
private unsafe ValueTask<int> ReadAsyncInternal(Memory<byte> destination, CancellationToken cancellationToken)
{
if (!CanRead)
{
Expand Down Expand Up @@ -143,5 +143,15 @@ await FileStreamHelpers
}
}
}

public override IAsyncResult BeginRead(byte[] buffer, int offset, int count, AsyncCallback? callback, object? state) =>
TaskToApm.Begin(ReadAsync(buffer, offset, count), callback, state);

public override int EndRead(IAsyncResult asyncResult) => TaskToApm.End<int>(asyncResult);

public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback? callback, object? state) =>
TaskToApm.Begin(WriteAsync(buffer, offset, count), callback, state);

public override void EndWrite(IAsyncResult asyncResult) => TaskToApm.End(asyncResult);
}
}