[Mono] Fix support for nested structs with explicit layout #61467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: Issue DetailsWIP Fixes #61385
|
simonrozsival
requested review from
lambdageek,
thaystg and
vargaz
as code owners
…zsival/61385-nested-struct-with-explicit-layout
lambdageek
approved these changes
Dec 1, 2021
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
LGTM. Thanks, Simon!
I suggested to use the m_class_XYZ getters for accessing MonoClass fields in a couple of places. Technically class-init.c is allowed to use the fields directly, it's probably a good idea to only do it when you're also initializing the MonoClass.
thaystg
reviewed
Dec 1, 2021
Member
Author
|
Thanks for the feedback @lambdageek! I replaced the direct accesses with those getters as you suggested. |
lambdageek
approved these changes
Dec 1, 2021
simonrozsival
deleted the
simonrozsival/61385-nested-struct-with-explicit-layout
branch
agocke
added a commit
to agocke/runtime
that referenced
this pull request
Dec 3, 2021
…otnet#61467)" This reverts commit 64d1276.
lambdageek
added a commit
to lambdageek/runtime
that referenced
this pull request
Dec 13, 2021
These were fixed by dotnet#61467 Related to dotnet#36112
lambdageek
added a commit
that referenced
this pull request
Dec 14, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of explicit struct layout check doesn't consider the layout of embedded value types. This new implementation recursively checks the inner structure of all embedded structs.
Fixes #61385