[tests] Re-enable some explicit layout tests on Mono #62746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were fixed by dotnet#61467 Related to dotnet#36112
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Need to disable most of these on llvmfullaot. I think it's expected that they wouldn't compile (since the AOT compiler will do layout at AOT time) |
As well as the NestedStructs tests. Resolves dotnet#62567
Member
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The runtime-manual failures aren't related |
simonrozsival
approved these changes
Dec 14, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were fixed by #61467
During full AOT compilation we try to load all of these problematic types, so AOT compilation will fail. As a result these tests are all expected to fail the llvmfullaot lanes.
Related to #36112
Fixes #62567