Skip to content

[wasm] Tweak set timeout #62898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2021
Merged

[wasm] Tweak set timeout #62898

merged 2 commits into from
Dec 22, 2021

Conversation

@maraf
Copy link
Member

@maraf maraf commented Dec 16, 2021

  • Cache method lookup for TimerQueue.TimeoutCallback and ThreadPool.Callback.
  • Remove unused parameter "id" from timer related functions.

@maraf maraf added the arch-wasm WebAssembly architecture label Dec 16, 2021
@maraf maraf added this to the 7.0.0 milestone Dec 16, 2021
@ghost ghost added the area-VM-meta-mono label Dec 16, 2021
@ghost ghost assigned maraf Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Cache method lookup for TimerQueue.TimeoutCallback and ThreadPool.Callback.
  • Remove unused parameter "id" from timer related functions.
Author: maraf
Assignees: -
Labels:

arch-wasm
Milestone: 7.0.0

@maraf
Copy link
Member Author

maraf commented Dec 16, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf requested review from kg and pavelsavara December 16, 2021 18:53
@maraf
Copy link
Member Author

maraf commented Dec 16, 2021

Some tests are failing. I'm not sure it's caused by my changes.

kg
kg reviewed Dec 16, 2021
View reviewed changes
@maraf maraf mentioned this pull request Dec 20, 2021
Merged
@maraf maraf force-pushed the WasmTweakSetTimeout branch from 20ad88f to 398f536 Compare December 21, 2021 11:38
@maraf maraf marked this pull request as ready for review December 21, 2021 11:39
@maraf
Copy link
Member Author

maraf commented Dec 21, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 21, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf merged commit 6f2fa80 into dotnet:main Dec 22, 2021
@maraf maraf deleted the WasmTweakSetTimeout branch December 22, 2021 09:45
@ghost ghost locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg left review comments

@pavelsavara pavelsavara pavelsavara approved these changes

@lambdageek lambdageek lambdageek approved these changes

@imhameed imhameed Awaiting requested review from imhameed

@marek-safar marek-safar Awaiting requested review from marek-safar

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@vargaz vargaz Awaiting requested review from vargaz

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-VM-meta-mono

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@maraf @kg @pavelsavara @lambdageek