mono_get_generic_info_from_stack_frame fix for default interface methods #64566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context is a MonoMethodRuntimeGenericContext when the method is a default interface method. Also re-enable broken DIM tests. Fixes dotnet/runtime dotnet#62334
ghost
added
area-VM-meta-mono
community-contribution
Contributor
Author
|
Later in mono_get_generic_context_from_stack_frame the code is treating the info address as a MonoMethodRuntimeGenericContext . This PR ensures that mono_get_generic_info_from_stack_frame assigns the info value consistently. |
Contributor
Author
|
If approved will need to update the Mono PR as well. mono/mono#21356 |
vargaz
approved these changes
Feb 1, 2022
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Feb 17, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context is a MonoMethodRuntimeGenericContext when the method is a
default interface method.
Also re-enable broken DIM tests.
Fixes dotnet/runtime #62334