[release/6.0] [mono] Fix stacktrace from DIM #65509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaystg
requested review from
BrzVlad,
imhameed,
lambdageek and
vargaz
as code owners
lambdageek
approved these changes
Feb 17, 2022
teo-tsirpanis
added
the
Servicing-consider
Contributor
|
Pardon me if I'm wrong but my understanding is that servicing PRs need to be tagged with c.c. @eiriktsarpalis |
Member
|
@teo-tsirpanis |
ilonatommy
reviewed
Feb 18, 2022
| StringSplitOptions.None | ||
| ); | ||
|
|
||
| //Console.WriteLine(testStack); |
Member
There was a problem hiding this comment.
Forgotten commented out value check :)
rbhanda
added
Servicing-approved
Member
|
aot failure is #66366 |
lewing
approved these changes
Mar 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60770 and #64566 to release/6.0
Fix an assertion when trying to get the callstack from a DIM.
Customer Impact
When trying to get the callstack from a DIM was hitting an assert and stopping the process.
Testing
Automatic tests added
Risk
Low Risk.