Delete some .NET Nativisms #73553
Merged
Delete some .NET Nativisms #73553
+21
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace MissingInteropDataException with NotSupportedException * Replace MissingRuntimeArtifactException with MissingMetadataException (it was already used as a MME in some spots anyway). I'll try to get rid of MME later. * Change the messages to refer to static analysis as the fix, not RD.XML. Open question: do we want an aka.ms link for these? We don't currently have a doc on "Making apps ready for NativeAOT", but we'll need one.
ghost
assigned
jkotas
approved these changes
Aug 8, 2022
vitek-karas
approved these changes
Aug 8, 2022
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
I think it would be good to have an aka.ms link for these.
Analyzer/compiler get away without one by producing a specific warning code - which has a document page, so we effectively have a landing page for each of the warnings. Exceptions don't have anything like that.
This was referenced Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open question: do we want an aka.ms link for these? We don't currently have a doc on "Making apps ready for NativeAOT", but we'll need one.
Cc @dotnet/ilc-contrib
Contributes to #69746.