Initial work to enable native events in EventPipe #84318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This was referenced Apr 4, 2023
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 9, 2023
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidwrighton
approved these changes
Apr 12, 2023
Member
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
Looks ok, but I'd like to see a signoff from someone actively working on NativeAOT as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for native event support to
EventPipe, with GC events seen with the RuntimeProvider, that matches the existingEtwProvidersupport inNativeAOT.Similar to the existing
EtwProviderwork inNativeAOT, theEventPipeProvidercode is checked in, as opposed to using the python generated code. Unlike theEtwProvider, the code is in the opt-inEventPipelibrary (eventpipe-enabled.lib). There is corresponding minimal implementation in the disabled defaultEventPipe(eventpipe-disabled.lib).Both managed and native events can be seen with tools like
PerfViewor dotnet-trace (collect option) by enabling the providers (in the native case, withMicrosoft-Windows-DotNETRuntimefor dotnet-trace and by selecting GC options inPerfView).There will be a future effort to enhance the existing GC events with the right set of native events for
NativeAOT.