Skip to content

JIT: ARM64 SVE format encodings, SVE_HY_3A to SVE_IB_3A #98468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 20, 2024
Merged

JIT: ARM64 SVE format encodings, SVE_HY_3A to SVE_IB_3A #98468

merged 9 commits into from
Feb 20, 2024

Conversation

@TIHan
Copy link
Contributor

@TIHan TIHan commented Feb 14, 2024 •
edited
Loading

Contributes to #94549

Adds formats:

  • SVE_HY_3A
  • SVE_HY_3A_A
  • SVE_HY_3B
  • SVE_IB_3A
  • SVE_HZ_2A_B
  • SVE_IA_2A

Left: Capstone,
Right: Jit
image

@ghost ghost assigned TIHan Feb 14, 2024
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 14, 2024
@ghost
Copy link

ghost commented Feb 14, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #94549

Adds formats:

  • SVE_HY_3A
  • SVE_HY_3A_A
  • SVE_HY_3B
  • SVE_IB_3A
  • SVE_HZ_2A_B
  • SVE_IA_2A

Left: Capstone,
Right: Jit
image

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr
Milestone: -

@TIHan TIHan mentioned this pull request Feb 14, 2024
Closed
TIHan
TIHan commented Feb 14, 2024
View reviewed changes
@TIHan
Copy link
Contributor Author

TIHan commented Feb 14, 2024

@dotnet/jit-contrib @dotnet/arm64-contrib @kunalspathak @a74nh this is ready.

@TIHan TIHan added the arm-sve Work related to arm64 SVE/SVE2 support label Feb 14, 2024
@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.osx.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.windows.arm64.checked.mch +0.01%

Details here

a74nh
a74nh reviewed Feb 15, 2024
View reviewed changes
a74nh
a74nh reviewed Feb 15, 2024
View reviewed changes
a74nh
a74nh reviewed Feb 15, 2024
View reviewed changes
a74nh
a74nh reviewed Feb 15, 2024
View reviewed changes
amanasifkhalid
amanasifkhalid reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once the _idSvePrfop/_idReg4 refactor is in.

@amanasifkhalid amanasifkhalid mentioned this pull request Feb 15, 2024
Merged
@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%
realworld.run.linux.arm64.checked.mch -0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
realworld.run.osx.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch +0.01%

Details here

@TIHan
Copy link
Contributor Author

TIHan commented Feb 17, 2024

@amanasifkhalid this is ready again

amanasifkhalid
amanasifkhalid approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.01% to +0.01%)
Collection PDIFF
libraries.pmi.linux.arm64.checked.mch +0.01%
realworld.run.linux.arm64.checked.mch -0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
realworld.run.osx.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch +0.01%

Details here

@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.linux.arm64.checked.mch +0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.osx.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.linux.arm64.checked.mch +0.01%

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
realworld.run.osx.arm64.checked.mch +0.01%

Throughput diffs for windows/arm64 ran on windows/x64

MinOpts (-0.01% to +0.00%)
Collection PDIFF
libraries.pmi.windows.arm64.checked.mch -0.01%

Details here

a74nh
a74nh approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryujit-bot
Copy link

Diff results for #98468

Throughput diffs

Throughput diffs for osx/arm64 ran on windows/x64

MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.osx.arm64.checked.mch +0.01%

Details here

@TIHan TIHan merged commit 95af2bc into dotnet:main Feb 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo left review comments

+3 more reviewers

@BruceForstall BruceForstall BruceForstall left review comments

@a74nh a74nh a74nh approved these changes

@amanasifkhalid amanasifkhalid amanasifkhalid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TIHan TIHan

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TIHan @ryujit-bot @EgorBo @a74nh @BruceForstall @amanasifkhalid