Configurable wwwroot for StaticWebAssets #34178
Conversation
ghost
added
the
|
Thanks for your PR, @maraf. |
| <ItemGroup> | ||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | ||
| </ItemGroup> | ||
| </Project> No newline at end of file |
There was a problem hiding this comment.
Can we avoid adding an extra test project for this?
| <!-- Wire-up static web assets --> | ||
| <PropertyGroup> | ||
| <ResolveStaticWebAssetsInputsDependsOn> | ||
| _EnsureStaticWebAssetRootPath; |
There was a problem hiding this comment.
I'm fine if we don't block people from changing this. But if we do, this should probably be in ResolveStaticWebAssetsConfiguration
There was a problem hiding this comment.
I remember you mentioned there are places where this is hardcoded in blazor codebase
| <!-- Publish everything under wwwroot, all JSON files, all config files and all Razor files --> | ||
| <Content Include="wwwroot\**" ExcludeFromSingleFile="true" CopyToPublishDirectory="PreserveNewest" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" /> | ||
| <!-- Publish everything under @(StaticWebAssetSourcePath), all JSON files, all config files and all Razor files --> | ||
| <Content Include="%(StaticWebAssetSourcePath->Identity)\**" ExcludeFromSingleFile="true" CopyToPublishDirectory="PreserveNewest" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" /> |
There was a problem hiding this comment.
Why can't this just be $(StaticWebAssetRootPath)\**
There was a problem hiding this comment.
That was my previous approach. With the current approach (which doesn't work yet :/ ) I'm trying to be able to have a nuget package with public folder, but target app with client folder. So that libraries/packages could be shared (if the actual code make sense to be shared).
Does it make sense to you?
Unfortunatelly this style of msbuild globing doesn't work outside of a target
| <!-- Input and output configuration --> | ||
| <PropertyGroup> | ||
| <StaticWebAssetRootPath Condition="'$(StaticWebAssetRootPath)' == ''">wwwroot</StaticWebAssetRootPath> | ||
| </PropertyGroup> | ||
| <ItemGroup Condition="@(StaticWebAssetSourcePath->Count()) == 0"> | ||
| <StaticWebAssetSourcePath Include="wwwroot" /> | ||
| </ItemGroup> | ||
|
|
There was a problem hiding this comment.
Do we actually need to make these input sources configurable? I would rather avoid this, as they are web specific. If people want to follow different conventions, that can be done in the project file directly.
There was a problem hiding this comment.
Intention described in the comment above..
| for (int i = 0; i < patterns.Length; i++) | ||
| matcher.AddInclude(patterns[i]); |
|
|
||
| [Required] | ||
| public string Pattern { get; set; } | ||
| public ITaskItem[] Patterns { get; set; } |
There was a problem hiding this comment.
Can we avoid taking multiple patterns here? This can be called via MSBuild batching from outside instead, and simplifies things.
2 participants
The goal of this PR is to be able to override both input and output folder of static web assets. We need such configuration for WebAssembly template targeting nodejs/v8/etc. The
wwwrootis not correct name in this context.StaticWebAssetRootPath(defaultwwwroot) allowing to configure target folder for static web assetsStaticWebAssetSourcePath(defaultwwwroot) allowing to configure source folder(s) static web assetssrc\Assets\TestProjects\RazorAppWithP2PReferenceWithSwaPathsStaticWebAssetRootPathis not wwwroot for Blazor Wasm project