Ignore external packages in package source generation #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
MichaelSimons
approved these changes
Apr 12, 2023
mthalman
reviewed
Apr 12, 2023
|
|
||
| <!-- External packages aren't visited as they shouldn't be added to SBRP. --> | ||
| <ItemGroup> | ||
| <ExternalPackage Include="Newtonsoft.Json" /> |
Member
There was a problem hiding this comment.
@MichaelSimons - Does this need to be version-specific at all? If/when there's a 14.0.0 version of Newtonsoft.Json, wouldn't we want to support repos continuing to reference the older 13.0.1 version?
Member
There was a problem hiding this comment.
I don't think so. To date we have never needed Newtonsoft.Json in SBRP. If multiple versions without CVEs are supported and required then we would add them to source-build-externals.
oleksandr-didyk
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#3364