Skip to content

Ignore external packages in package source generation #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Ignore external packages in package source generation #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/packageSourceGenerator/PackageSourceGenerator.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,16 @@
<TargetingPackage Include="Microsoft.AspNetCore.App.Ref" />
<TargetingPackage Include="Microsoft.WindowsDesktop.App.Ref" />
</ItemGroup>

<!-- External packages aren't visited as they shouldn't be added to SBRP. -->
<ItemGroup>
<ExternalPackage Include="Newtonsoft.Json" />
Copy link
Member

@mthalman mthalman Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSimons - Does this need to be version-specific at all? If/when there's a 14.0.0 version of Newtonsoft.Json, wouldn't we want to support repos continuing to reference the older 13.0.1 version?

Copy link
Member

@MichaelSimons MichaelSimons Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. To date we have never needed Newtonsoft.Json in SBRP. If multiple versions without CVEs are supported and required then we would add them to source-build-externals.

</ItemGroup>

<ItemGroup>
<FilteredPackageDependency Include="@(PackageDependency)"
Exclude="@(TargetingPackage)" />
Exclude="@(TargetingPackage);
@(ExternalPackage)" />
</ItemGroup>

<MSBuild Projects="$(MSBuildThisFileFullPath)"
Expand Down