Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

SBRPs required for vstest per-repo prebuilts work: microsoft/vstest#4405

Microsoft.Build.Framework.16.0.461
Microsoft.Build.Utilities.Core.16.0.461
Microsoft.Extensions.FileSystemGlobbing.2.0.0
NuGet.Frameworks.5.11.0

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see vstest upgrade to some newer versions. If that is not feasible I am alright with the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incredibly old version - 2017. Is it feasible to upgrade to a newer version possible on already in SBRP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty old version - 2019. What is the feasibility of getting them to upgrade to a newer version? Preferrably one in SBRP.

@NikolaMilosavljevic
Copy link
Member Author

Would be nice to see vstest upgrade to some newer versions. If that is not feasible I am alright with the changes.

I'm going to inquire, but I'm hesitant to further delay vstest onboarding to per-repo prebuilts verification. Would it help if we had issues in vstest to request updates to newer versions?

Otoh, we are still adding older versions for some other repos, i.e. #602

@MichaelSimons
Copy link
Member

I agree we should not delay prebuilt detection. We should log a follow-up issue for them to upgrade.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 4bf273e into dotnet:main Apr 25, 2023
@NikolaMilosavljevic
Copy link
Member Author

Created a tracking issue for old packages: microsoft/vstest#4418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants