Skip to content

Added support for transaction.name in an error object to the intake API #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

Added support for transaction.name in an error object to the intake API #6539

merged 3 commits into from
Nov 4, 2021

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Nov 4, 2021

Motivation/summary

Fixes #6529

Checklist

How to test these changes

I added unit tests

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

This pull request does not have a backport label. Could you fix it @tobiasstadler? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@tobiasstadler tobiasstadler changed the title Added support for transaction.name to the intake API Added support for transaction.name in an error object to the intake API Nov 4, 2021
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Nov 4, 2021

I ran make update this time

@ghost
Copy link

ghost commented Nov 4, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-04T09:23:38.985+0000

  • Duration: 39 min 27 sec

  • Commit: 290b38d

Test stats 🧪

Test Results
Failed 0
Passed 6258
Skipped 19
Total 6277

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

axw
axw approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, you're quick :) Thank you!

@axw axw added the backport-8.0 Automated backport with mergify label Nov 4, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 4, 2021
@axw axw added the v8.0.0 label Nov 4, 2021
@axw
Copy link
Member

axw commented Nov 4, 2021

/test

@axw axw merged commit fe1db82 into elastic:master Nov 4, 2021
mergify bot pushed a commit that referenced this pull request Nov 4, 2021
@tobiasstadler
Added support for transaction.name in an error object to the intake A…
534eb50 
…PI (#6539)

* Added support for transaction.name to the intake API

* Added #6539 to the changelog

* Improved Changelog

(cherry picked from commit fe1db82)
@mergify mergify bot mentioned this pull request Nov 4, 2021
Merged
This was referenced Nov 4, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Nov 4, 2021

Thank You!

@tobiasstadler tobiasstadler deleted the fix-6529 branch November 4, 2021 10:16
@tobiasstadler tobiasstadler mentioned this pull request Nov 4, 2021
Merged
2 tasks
marclop pushed a commit that referenced this pull request Nov 4, 2021
@mergify @tobiasstadler
Added support for transaction.name in an error object to the intake A…
74a2ccb 
…PI (#6539) (#6542)

* Added support for transaction.name to the intake API

* Added #6539 to the changelog

* Improved Changelog

(cherry picked from commit fe1db82)

Co-authored-by: Tobias Stadler <[email protected]>
This was referenced Nov 4, 2021
Closed
Closed
Merged
This was referenced Nov 4, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
@stuartnelson3
Copy link
Contributor

stuartnelson3 commented Dec 20, 2021

test plan: ingest an error, verify transaction.name is set

@marclop marclop self-assigned this Dec 21, 2021
@marclop
Copy link
Contributor

marclop commented Dec 21, 2021

Tested locally ingesting some errors with 8.0.0-dev4 package but we missed adding the transaction.name field mapping to the data stream:

Error detail

image

Data Stream mapping

image

@marclop marclop mentioned this pull request Dec 21, 2021
Merged
@marclop
Copy link
Contributor

marclop commented Dec 28, 2021

Verified this with 42889b4, which contains the linked PR's fix.

@trentm trentm mentioned this pull request Jan 19, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axw axw axw approved these changes

Assignees

@marclop marclop

Labels

backport-8.0 Automated backport with mergify test-plan test-plan-ok v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow transaction.name in error events

4 participants

@tobiasstadler @axw @stuartnelson3 @marclop