Skip to content

Conversation

@andrzej-stencel
Copy link
Contributor

What does this PR do?

Removes the Elastic Trace processor from EDOT Collector, replacing all usages with its direct drop-in replacement, the Elastic APM processor.

Why is it important?

The Elastic Trace processor was deprecated and its code was removed in elastic/opentelemetry-collector-components#784.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

This is a breaking change for users if they use the processor in their EDOT Collector configurations.

The fix is simple: replace elastictrace with elasticapm in their configurations.

How to test this PR locally

go build .
sudo ./elastic-aget otel components

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2025

This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

It is replaced with the Elastic APM processor.
@andrzej-stencel andrzej-stencel force-pushed the replace-elastic-trace-processor-with-elastic-apm-processor branch from e07e280 to c1e9b4e Compare October 7, 2025 13:29
Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please revert the changes in components.md and custom-collector.md, since those docs are meant to show the latest stable release (9.1.5) and will update automatically upon 9.2 release.

I would also recommend to edit all the other sample configurations and backport (forwardport?) the changes to the cut 9.2 branch.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 7, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

andrzej-stencel added a commit to andrzej-stencel/elastic-agent that referenced this pull request Oct 7, 2025
@andrzej-stencel andrzej-stencel added the backport-9.2 Automated backport to the 9.2 branch label Oct 7, 2025
@andrzej-stencel
Copy link
Contributor Author

Please revert the changes in components.md and custom-collector.md, since those docs are meant to show the latest stable release (9.1.5) and will update automatically upon 9.2 release.

Right, fixed in 56127ab.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andrzej-stencel

@ycombinator ycombinator enabled auto-merge (squash) October 7, 2025 22:29
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregkalapos mind taking a look too?

@ycombinator ycombinator merged commit 6c2491c into elastic:main Oct 8, 2025
21 checks passed
mergify bot pushed a commit that referenced this pull request Oct 8, 2025
* feat!: remove Elastic Trace processor from EDOT Collector

It is replaced with the Elastic APM processor.

* fix: add Elastic APM processor to custom collector docs

* revert changes in docs

* fix component order in docs

(cherry picked from commit 6c2491c)
@andrzej-stencel andrzej-stencel deleted the replace-elastic-trace-processor-with-elastic-apm-processor branch October 8, 2025 08:13
@gregkalapos
Copy link
Contributor

We just had a zoom call with @andrzej-stencel and @AlexanderWert and concluded that removing this processor would be a breaking change, which we'd like to avoid.

On the other hand, the code of the elastic trace processor is already removed from the collector components repo, so the last version depends on older upstream components, which makes bumping versions harder - so this would have not worked probably anyways as it was in this repo.

Plan is that I'll try to create a small processor with the same name elastictraceprocessor in the component repo, which just forwards to the new elasticapmprocessor. But if we want to avoid breaking changes, we'll need a follow up PR and add back elastictraceprocessor with the new version.

andrzej-stencel added a commit that referenced this pull request Oct 8, 2025
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry
mergify bot pushed a commit that referenced this pull request Oct 8, 2025
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry

(cherry picked from commit 7ea323e)

# Conflicts:
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
andrzej-stencel added a commit that referenced this pull request Oct 8, 2025
…10406)

* feat!: remove Elastic Trace processor from EDOT Collector

It is replaced with the Elastic APM processor.

* fix: add Elastic APM processor to custom collector docs

* revert changes in docs

* fix component order in docs

(cherry picked from commit 6c2491c)

Co-authored-by: Andrzej Stencel <[email protected]>
andrzej-stencel added a commit that referenced this pull request Oct 8, 2025
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry

(cherry picked from commit 7ea323e)

# Conflicts:
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md

Co-authored-by: Andrzej Stencel <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry

(cherry picked from commit 7ea323e)

# Conflicts:
#	NOTICE-fips.txt
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
pkoutsovasilis pushed a commit that referenced this pull request Oct 16, 2025
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry

(cherry picked from commit 7ea323e)

# Conflicts:
#	NOTICE-fips.txt
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
pkoutsovasilis added a commit that referenced this pull request Oct 16, 2025
….137.0 (#10543)

* feat: update OTel Collector components to v0.137.0 (#10391)

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod

* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod

* sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod

* go mod tidy

* update Elastic components

* remove Elastic Trace processor

In anticipation of #10378

* go get go.opentelemetry.io/[email protected]

* go mod tidy

* add changelog entry

(cherry picked from commit 7ea323e)

# Conflicts:
#	NOTICE-fips.txt
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md

* fix: resolve conflicts

* fix: StartMockES

* [otel] Add back elastictrace processor

* fix: resolve gaps from rebasing

* fix: unit-tests

* fix: update beats to latest version on 8.19

* fix: otelconfig_test.go

---------

Co-authored-by: Andrzej Stencel <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.2 Automated backport to the 9.2 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants