Skip to content

[fix] Add url validation in HttpFetcher.Fetch #10452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 14, 2025
Merged

[fix] Add url validation in HttpFetcher.Fetch #10452

merged 8 commits into from
Oct 14, 2025

Conversation

hayotbisonai
Copy link
Contributor

@hayotbisonai hayotbisonai commented Oct 9, 2025 •
edited
Loading

What does this PR do?

  • url check in Fetch to ensure baseURL is valid and prevent runtime errors
  • included tests with invalid baseURL

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@hayotbisonai hayotbisonai requested a review from a team as a code owner October 9, 2025 13:33
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

This pull request does not have a backport label. Could you fix it @hayotbisonai? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@hayotbisonai hayotbisonai changed the title [fix] url validation in HttpFetcher.Fetch [fix] Adding url validation in HttpFetcher.Fetch Oct 9, 2025
@hayotbisonai hayotbisonai changed the title [fix] Adding url validation in HttpFetcher.Fetch [fix] Add url validation in HttpFetcher.Fetch Oct 9, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 9, 2025
@blakerouse
Copy link
Contributor

@hayotbisonai Thanks for the contribution. Change looks good overall, thanks for the extra check. Once it shows a green CI, I will give an approval.

@blakerouse blakerouse added the backport-active-all Automated backport with mergify to all the active branches label Oct 9, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

rubenruizdegauna
rubenruizdegauna reviewed Oct 10, 2025
View reviewed changes
@pchila
Copy link
Member

pchila commented Oct 10, 2025

buildkite test this

rubenruizdegauna
rubenruizdegauna approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna rubenruizdegauna merged commit ffcf093 into elastic:main Oct 14, 2025
22 of 23 checks passed
@github-actions GitHub Actions
Copy link
Contributor

@Mergifyio backport 8.18 8.19 9.0 9.1 9.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2025 •
edited
Loading

backport 8.18 8.19 9.0 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 14, 2025
@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
120de8a 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
abf03ab 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
This was referenced Oct 14, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
0b755d9 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
@mergify mergify bot mentioned this pull request Oct 14, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
40ea531 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
@mergify mergify bot mentioned this pull request Oct 14, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Oct 14, 2025
@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
9935ec3 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
@mergify mergify bot mentioned this pull request Oct 14, 2025
Merged
8 tasks
pierrehilbert pushed a commit that referenced this pull request Oct 14, 2025
@mergify @hayotbisonai
[fix] Add url validation in HttpFetcher.Fetch (#10452) (#10531)
8a36875 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)

Co-authored-by: Barkhayot <[email protected]>
rubenruizdegauna pushed a commit that referenced this pull request Oct 14, 2025
@mergify @hayotbisonai
[fix] Add url validation in HttpFetcher.Fetch (#10452) (#10533)
8c045d5 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)

Co-authored-by: Barkhayot <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Oct 14, 2025
@mergify @hayotbisonai
[fix] Add url validation in HttpFetcher.Fetch (#10452) (#10534)
5331b06 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)

Co-authored-by: Barkhayot <[email protected]>
pierrehilbert pushed a commit that referenced this pull request Oct 14, 2025
@mergify @hayotbisonai
[fix] Add url validation in HttpFetcher.Fetch (#10452) (#10535)
337a908 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)

Co-authored-by: Barkhayot <[email protected]>
rubenruizdegauna pushed a commit that referenced this pull request Oct 16, 2025
@mergify @hayotbisonai
[fix] Add url validation in HttpFetcher.Fetch (#10452) (#10532)
6ae0e44 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)

Co-authored-by: Barkhayot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

@pkoutsovasilis pkoutsovasilis Awaiting requested review from pkoutsovasilis pkoutsovasilis is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@hayotbisonai hayotbisonai

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hayotbisonai @blakerouse @elasticmachine @pchila @rubenruizdegauna @pierrehilbert