Skip to content

[8.19] (backport #10452) [fix] Add url validation in HttpFetcher.Fetch #10532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

[8.19] (backport #10452) [fix] Add url validation in HttpFetcher.Fetch #10532

merged 1 commit into from
Oct 16, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 14, 2025

What does this PR do?

  • url check in Fetch to ensure baseURL is valid and prevent runtime errors
  • included tests with invalid baseURL

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...
This is an automatic backport of pull request #10452 done by [Mergify](https://mergify.com).

@hayotbisonai @mergify
[fix] Add url validation in HttpFetcher.Fetch (#10452)
abf03ab 
* feat: url parser error check

* feat: fetcher test with invalid url

* fix: remove error check

* fix: remove test case

* fix: move url validator check into httpFetcherResult method

* fix: test case

(cherry picked from commit ffcf093)
@mergify mergify bot added the backport label Oct 14, 2025
@mergify mergify bot requested a review from a team as a code owner October 14, 2025 06:49
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team October 14, 2025 06:49
@mergify mergify bot added the backport label Oct 14, 2025
@mergify mergify bot mentioned this pull request Oct 14, 2025
Merged
8 tasks
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Oct 14, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

rubenruizdegauna
rubenruizdegauna approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenruizdegauna rubenruizdegauna merged commit 6ae0e44 into 8.19 Oct 16, 2025
20 checks passed
@rubenruizdegauna rubenruizdegauna deleted the mergify/bp/8.19/pr-10452 branch October 16, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rubenruizdegauna rubenruizdegauna rubenruizdegauna approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

No one assigned

Labels

backport skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elasticmachine @rubenruizdegauna @hayotbisonai