Implement v_magnitude function #132765

svilen-mihaylov-elastic · 2025-08-12T18:41:05Z

Implements #132768

…ov-elastic/elasticsearch into svilen/v_magnitude

github-actions · 2025-08-13T15:30:34Z

🔍 Preview links for changed docs

docs/reference/query-languages/esql/kibana/docs/functions/v_magnitude.md

...lasticsearch/xpack/esql/expression/function/vector/AbstractVectorScalarFunctionTestCase.java

svilen-mihaylov-elastic · 2025-08-13T16:43:36Z

...icsearch/xpack/esql/expression/function/vector/AbstractVectorSimilarityFunctionTestCase.java

        return floatArray;
    }

-    protected double calculateSimilarity(List<Float> left, List<Float> right) {


...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Magnitude.java

...rc/internalClusterTest/java/org/elasticsearch/xpack/esql/vector/VectorScalarFunctionsIT.java

...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Magnitude.java

.../main/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorScalarFunction.java

...lasticsearch/xpack/esql/expression/function/vector/AbstractVectorScalarFunctionTestCase.java

...icsearch/xpack/esql/expression/function/vector/AbstractVectorSimilarityFunctionTestCase.java

…expression/function/vector/Magnitude.java Co-authored-by: Carlos Delgado <[email protected]>

…expression/function/vector/AbstractVectorScalarFunctionTestCase.java Co-authored-by: Carlos Delgado <[email protected]>

…expression/function/vector/VectorScalarFunction.java Co-authored-by: Carlos Delgado <[email protected]>

.../main/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorScalarFunction.java

svilen-mihaylov-elastic · 2025-08-14T11:47:25Z

...ql/src/test/java/org/elasticsearch/xpack/esql/expression/function/vector/MagnitudeTests.java

+            float[] array = listToFloatArray(input);
+            double expected = scalarFunction.calculateScalar(array);
+            return new TestCaseSupplier.TestCase(
+                List.of(new TestCaseSupplier.TypedData(input, DENSE_VECTOR, "vector")),


@carlosdelest thanks for updating this!

carlosdelest

LGTM.

A couple of suggestions for you to evaluate, but looks really good! 💯

docs/changelog/132765.yaml

x-pack/plugin/esql/qa/testFixtures/src/main/resources/vector-magnitude.csv-spec

...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Magnitude.java

Co-authored-by: Carlos Delgado <[email protected]>

…expression/function/vector/Magnitude.java Co-authored-by: Carlos Delgado <[email protected]>

…agnitude.csv-spec Co-authored-by: Carlos Delgado <[email protected]>

…ov-elastic/elasticsearch into svilen/v_magnitude

* upstream/main: (32 commits) Speed up loading keyword fields with index sorts (elastic#132950) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testSyntheticSourceWithTranslogSnapshot elastic#132964 Simplify EsqlSession (elastic#132848) Implement WriteLoadConstraintDecider#canAllocate (elastic#132041) Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/400_synthetic_source/_doc_count} elastic#132965 Switch to PR-based benchmark pipeline defined in ES repo (elastic#132941) Breakdown undesired allocations by shard routing role (elastic#132235) Implement v_magnitude function (elastic#132765) Introduce execution location marker for better handling of remote/local compatibility (elastic#132205) Mute org.elasticsearch.cluster.ClusterInfoServiceIT testMaxQueueLatenciesInClusterInfo elastic#132957 Unmuting simulate index data stream mapping overrides yaml rest test (elastic#132946) Remove CrossClusterCancellationIT.createLocalIndex() (elastic#132952) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testFetch elastic#132956 Fix failing UT by adding a required capability (elastic#132947) Precompute the BitsetCacheKey hashCode (elastic#132875) Adding simulate ingest effective mapping (elastic#132833) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testFetchMany elastic#132948 Rename skipping logic to remove hard link to skip_unavailable (elastic#132861) Store ignored source in unique stored fields per entry (elastic#132142) Add random tests with match_only_text multi-field (elastic#132380) ...

Implements v_magnitude ESQL function

…-stats * upstream/main: (36 commits) Fix reproducability of builds against Java EA versions (elastic#132847) Speed up loading keyword fields with index sorts (elastic#132950) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testSyntheticSourceWithTranslogSnapshot elastic#132964 Simplify EsqlSession (elastic#132848) Implement WriteLoadConstraintDecider#canAllocate (elastic#132041) Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/400_synthetic_source/_doc_count} elastic#132965 Switch to PR-based benchmark pipeline defined in ES repo (elastic#132941) Breakdown undesired allocations by shard routing role (elastic#132235) Implement v_magnitude function (elastic#132765) Introduce execution location marker for better handling of remote/local compatibility (elastic#132205) Mute org.elasticsearch.cluster.ClusterInfoServiceIT testMaxQueueLatenciesInClusterInfo elastic#132957 Unmuting simulate index data stream mapping overrides yaml rest test (elastic#132946) Remove CrossClusterCancellationIT.createLocalIndex() (elastic#132952) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testFetch elastic#132956 Fix failing UT by adding a required capability (elastic#132947) Precompute the BitsetCacheKey hashCode (elastic#132875) Adding simulate ingest effective mapping (elastic#132833) Mute org.elasticsearch.index.mapper.LongFieldMapperTests testFetchMany elastic#132948 Rename skipping logic to remove hard link to skip_unavailable (elastic#132861) Store ignored source in unique stored fields per entry (elastic#132142) ...

v_magnitude

79f6ba4

elasticsearchmachine added the v9.2.0 label Aug 12, 2025

svilen-mihaylov-elastic added 13 commits August 12, 2025 14:44

Add verifier test

0a80914

add csv spec test

8a9967f

Add tests

c09f349

Fix function

bf661a5

various fixes

035b14d

floats

722b2f9

Fixes

e1e4f96

Merge branch 'main' into svilen/v_magnitude

f9035d6

Add integration test

3f7dfb7

rename

d7bf82a

Merge branch 'main' into svilen/v_magnitude

e9c5d0c

Disable folding for now

6feed0b

Merge branch 'svilen/v_magnitude' of https://github.com/svilen-mihayl…

427c703

…ov-elastic/elasticsearch into svilen/v_magnitude

[CI] Auto commit changes from spotless

cc5f4f7

svilen-mihaylov-elastic requested review from a team and carlosdelest August 13, 2025 16:40

svilen-mihaylov-elastic marked this pull request as ready for review August 13, 2025 16:41

svilen-mihaylov-elastic changed the title ~~v_magnitude~~ Implement v_magnitude function Aug 13, 2025

elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 13, 2025

svilen-mihaylov-elastic commented Aug 13, 2025

View reviewed changes

...lasticsearch/xpack/esql/expression/function/vector/AbstractVectorScalarFunctionTestCase.java Outdated Show resolved Hide resolved

svilen-mihaylov-elastic commented Aug 13, 2025

View reviewed changes

...in/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Magnitude.java Show resolved Hide resolved

carlosdelest reviewed Aug 13, 2025

View reviewed changes

svilen-mihaylov-elastic and others added 3 commits August 13, 2025 13:08

Update x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/…

a5091ad

…expression/function/vector/Magnitude.java Co-authored-by: Carlos Delgado <[email protected]>

Update x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/…

ad880d9

…expression/function/vector/AbstractVectorScalarFunctionTestCase.java Co-authored-by: Carlos Delgado <[email protected]>

Update x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/…

68d79a4

…expression/function/vector/VectorScalarFunction.java Co-authored-by: Carlos Delgado <[email protected]>

svilen-mihaylov-elastic commented Aug 13, 2025

View reviewed changes

.../main/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorScalarFunction.java Outdated Show resolved Hide resolved

svilen-mihaylov-elastic added 2 commits August 13, 2025 14:16

Merge branch 'main' into svilen/v_magnitude

1f39b8f

Address feedback

3743261

svilen-mihaylov-elastic requested a review from carlosdelest August 13, 2025 18:27

svilen-mihaylov-elastic and others added 8 commits August 13, 2025 14:57

Merge with abstract class

3ce2f53

Merge branch 'main' into svilen/v_magnitude

08ecefd

Fix typing

98c3d9b

Merge branch 'main' into svilen/v_magnitude

743804c

Fix test by using List as an input parameter

1691bff

Get back row() to being final

5d1effc

Merge branch 'main' into svilen/v_magnitude

bbd72b8

Fix merge

612ca48

svilen-mihaylov-elastic commented Aug 14, 2025

View reviewed changes

svilen-mihaylov-elastic added 2 commits August 14, 2025 08:32

Add docs

2a9a64d

Merge branch 'main' into svilen/v_magnitude

eb3d0f6

carlosdelest approved these changes Aug 14, 2025

View reviewed changes

svilen-mihaylov-elastic and others added 11 commits August 14, 2025 14:22

Update docs/changelog/132765.yaml

84df3be

Co-authored-by: Carlos Delgado <[email protected]>

Update x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/…

35b5f6c

…expression/function/vector/Magnitude.java Co-authored-by: Carlos Delgado <[email protected]>

Update x-pack/plugin/esql/qa/testFixtures/src/main/resources/vector-m…

c542420

…agnitude.csv-spec Co-authored-by: Carlos Delgado <[email protected]>

Merge branch 'main' into svilen/v_magnitude

db3e76d

Fix merge

b7e9933

Merge branch 'main' into svilen/v_magnitude

4c7657a

Merge branch 'main' into svilen/v_magnitude

cbd7d33

Merge branch 'main' into svilen/v_magnitude

d1b9fbe

Fix name

0828de8

Merge branch 'svilen/v_magnitude' of https://github.com/svilen-mihayl…

e24f914

…ov-elastic/elasticsearch into svilen/v_magnitude

Merge branch 'main' into svilen/v_magnitude

fd46a72

svilen-mihaylov-elastic merged commit 175cce4 into elastic:main Aug 14, 2025
33 checks passed

joshua-adams-1 pushed a commit to joshua-adams-1/elasticsearch that referenced this pull request Aug 15, 2025

Implement v_magnitude function (elastic#132765)

e6b86ef

Implements v_magnitude ESQL function

Implement v_magnitude function #132765

Implement v_magnitude function #132765

Uh oh!

Conversation

svilen-mihaylov-elastic commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

Uh oh!

svilen-mihaylov-elastic Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svilen-mihaylov-elastic Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

carlosdelest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

svilen-mihaylov-elastic commented Aug 12, 2025 •

edited

Loading

github-actions bot commented Aug 13, 2025 •

edited

Loading