Added :jvm-options-parser subproject to the javaTests task #15957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @andsel |
|
@logstashmachine backport 8.13 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
Adds a global new task named javaTests which groups both :logstash-core:javaTests and :jvm-options-parser:test to include the JvmOptionParser unit test in javaTests phase. (cherry picked from commit c30fe46)
Merged
2 tasks
andsel
added a commit
that referenced
this pull request
Feb 19, 2024
…15958) Adds a global new task named javaTests which groups both :logstash-core:javaTests and :jvm-options-parser:test to include the JvmOptionParser unit test in javaTests phase. (cherry picked from commit c30fe46) Co-authored-by: Andrea Selva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Adds a global new task named
javaTestswhich groups both:logstash-core:javaTestsand:jvm-options-parser:testto include the JvmOptionParser unit test in javaTests phase.Why is it important/What is the impact to the user?
The submodule
jvm-options-parseris used in the Logstash JVM bootstrap process, so has to be part of the continuous integration test suites.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs