-
Notifications
You must be signed in to change notification settings - Fork 3.5k
qa: fix integration by including built gems #17165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the result of invoking the previouly-checked-in script: ~~~ qa/integration/fixtures/plugins/generate-gems.sh ~~~
|
💛 Build succeeded, but was flaky
Failed CI Steps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking in compiled gems, should we just invoke https://github.com/elastic/logstash/blob/main/qa/integration/fixtures/plugins/generate-gems.sh as part of test setup?
|
OK. Integration tests weren't failing because buildkite has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think the tests that depend on this are actually being run in CI when they should? For example: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1386#01953de7-7260-4b11-91aa-721dece635d9
CLI > logstash-plugin remove
--
| without internet connection (linux seccomp wrapper)
| when other plugins depends on this plugin
| expunging(/buildkite/builds/bk-agent-prod-k8s-1740500368221313042/elastic/logstash-exhaustive-tests-pipeline/build/qa-fixture/logstash-9.1.0-SNAPSHOT)
| expanding(/buildkite/builds/bk-agent-prod-k8s-1740500368221313042/elastic/logstash-exhaustive-tests-pipeline/build/logstash-9.1.0-SNAPSHOT.tar.gz)
| Using /buildkite/builds/bk-agent-prod-k8s-1740500368221313042/elastic/logstash-exhaustive-tests-pipeline/build/qa-fixture/logstash-9.1.0-SNAPSHOT as LS_HOME
| Setting up services
| Setting up logstash service
| Setup script not found for logstash
| logstash service setup complete
|
| rm -f offline offline.o
| cc -c -o offline.o offline.c
| cc -o offline offline.o
I think the tests are in a
| context "when removing plugins and all plugins that depend on them" do |
else block regardless of OS and ONLY run the tests in the if block if we are on linux. I think the way its structured now is on linux we ONLY run the tests in the if block, but we actually want everything in that file.
|
I merged #17171, which has the alternate fix. |





Release notes
[rn:skip]
What does this PR do?
Checks in the gems that are needed for plugin removal integration tests introduced in #17030 and backported to
8.xand9.0This is the result of invoking the previouly-checked-in script:
Why is it important/What is the impact to the user?
Build fix.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Observe the buildkite integration tests for
cli/remove_specsucceeding.