qa: don't bypass plugin manger tests on linux #17171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hopefully this will expose failures due to needing #17165 . Looks like artifacts-api is struggling again ⌛ |
donoghuc
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Tests are running now!
| rspec ./specs/cli/remove_spec.rb:206 # CLI > logstash-plugin remove multiple plugins when removing plugins and all plugins that depend on them removes the plugins
| rspec ./specs/cli/remove_spec.rb:179 # CLI > logstash-plugin remove multiple plugins when multiple remaining plugins have a dependency on a removed plugin errors helpfully without removing any of the plugins
| rspec ./specs/cli/remove_spec.rb:153 # CLI > logstash-plugin remove multiple plugins when a remaining plugin has a dependency on a removed plugin errors helpfully without removing any of the plugins
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
|
@logstashmachine backport 9.0 |
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* qa: don't bypass plugin manger tests on linux * add gradle task to build gem fixtures for integration tests (cherry picked from commit 0f81816)
2 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
* qa: don't bypass plugin manger tests on linux * add gradle task to build gem fixtures for integration tests (cherry picked from commit 0f81816)
2 tasks
yaauie
added a commit
that referenced
this pull request
Feb 27, 2025
* qa: don't bypass plugin manger tests on linux * add gradle task to build gem fixtures for integration tests (cherry picked from commit 0f81816) Co-authored-by: Ry Biesemeyer <[email protected]>
yaauie
added a commit
that referenced
this pull request
Feb 27, 2025
* qa: don't bypass plugin manger tests on linux * add gradle task to build gem fixtures for integration tests (cherry picked from commit 0f81816) Co-authored-by: Ry Biesemeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
When run on
host_os==linux, some plugin manager integration specs are run with an airgap wrapper, but the other tests are bypassed because they are in anelseclause.This PR moves the non-airgap tests out of the
elseclause so that they will be run in buildkite CI.NOTE: best reviewed ignoring whitespace changes
Why is it important/What is the impact to the user?
no user impact
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs