[3.16] Support semanticTokens missing methods

[ericdallo]

SPEC
lsp-mode is missing the implementation of:

• ↩️ textDocument/semanticTokens/full/delta witch should improve performance bringing only the tokens relative to existing ones
• ⬅️ workspace/semanticTokens/refresh not critical, which allows server request client to refresh the tokens at any time.

[ericdallo]

Hey @sebastiansturm willing to take a took? specially the delta request?

I implemented on clojure-lsp both range and full semantic-tokens, it's missing only the delta for full support :D

[sebastiansturm]

yep, will have a look!

[sebastiansturm]

if anyone would like to test this, I have a preliminary implementation at sebastiansturm/lsp-mode, but I haven't opened a PR yet as I'll need to test it with lsp-use-plists enabled, and with a language server that sends out refresh requests. Plan to do that later this week

[ericdallo]

cool @sebastiansturm I can test it, I implemented clojure lsp server support for semantic tokens recently, but no refresh yet, but I can do if it's needed

[ericdallo]

I noticed some bugs on lsp-mode regarding delaying the tokens updates and for a small amount of time the tokens just got white before apply the tokens instead of use the major mode faces, I hope this branch fixes it too!

[sebastiansturm]

I'm not a clojure developer but I'll gladly use the clojure server for testing if you'll implement support, otherwise I'll try with the lua language server (as far as I understand, someone recently had issues with lua lsp sending out refresh requests, so apparently the support is there).
As for the delay, I haven't noticed that even with the current implementation, except when tree-sitter-hl mode was enabled; that's something I'll have to take a look at. Did you use tree-sitter-hl when you noticed that issue?

[ericdallo]

I'm not sure when should server should send refresh notification, do you have an example?
Never heard of that tree-sitter-hl 😆

[ericdallo]

Hey @sebastiansturm, good news, my issue with some tokens not being updates were gone with your branch :D
I'll keep testing it with clojure and let you know if any bugs

[ericdallo]

Actually, still happens not so small files, check the gif:

Here, clojure-lsp return the purple color as a macro token for deftest, testing and is for example, it seems that the first request works, but if I scroll or go back it has a lot of tokens not purple...
Also if I edit the file, lsp-mode request new tokens and sometime works:

[sebastiansturm]

thanks for the bug report! I haven't seen this kind of behavior myself (unless, as mentioned, tree-sitter-hl was enabled), but I'll try to install clojure-lsp this evening and reproduce the issue myself. If that doesn't work out, I'll have a look this weekend at what happens with tree-sitter enabled, maybe for some reason the same underlying issue occurs with your configuration