Address #2448 #2790
Address #2448 #2790
Conversation
lsp-semantic-tokens.el
Outdated
| Note that even when this is set to t, delta requests will | ||
| be preferred whenever possible, unless | ||
| `lsp-semantic-tokens-allow-delta-requests' is false." | ||
| :group 'lsp-mode |
There was a problem hiding this comment.
Could you change the groups to lsp-semantic-tokens to make those variables documentation show in correct sections of webpage?
|
@sebastiansturm I realized I didn't implement delta support for clojure-lsp yet, I'll use this branch as a base to implement the server |
|
@sebastiansturm Would you mind merge master in this branch? I intend to test latest changes and this branch this week |
I just rebased and pushed. Got some error message during fontification with rust-analyzer that I'll have to look into in the following days, but I pushed the current state anyway since semantic tokens seemed to work as usual with clojure-lsp. Thanks for testing! |
* lsp-semantic-tokens-enable-log advises lsp-semantic-tokens--fontify to store buffer snapshots before and after fontification * lsp-semantic-tokens-disable-log unadvises lsp-semantic-tokens--fontify (completely, assuming that users typically don't define custom advice for lsp-semantic-tokens--fontify) * lsp-semantic-tokens-export-log converts logs generated by lsp-semantic-tokens-enable-log to a list of HTML files stored under /tmp/semantic-token-snapshots; requires 'htmlize
should be a request handler, not a notification handler
|
@sebastiansturm I tested this PR with clojure-lsp and found no major issues with semantic tokens full and range, I couldn't test delta but this seems to have improvements on semantic-tokens on general, so LGTM to merge, WDYT? |
|
at least I'm not aware of any open issues since the CI failures have been resolved, and I didn't run into problems using it myself. So if you didn't either, then I think it's probably good enough to merge. Thanks for your help! |
2 participants
this PR adds support for delta and refresh requests and fixes flickering seen in combination with some underlying highlighting mechanisms (tree-sitter-hl, clojure's syntax highlighter)
Fixes #2448