Skip to content

fix: map moves to origin when double-clicking #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
Merged

fix: map moves to origin when double-clicking #2651

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56756bd
Fixed `scaledCoordinate` not being in extended pick return
Anders2303 Oct 24, 2025
a7e101d
removed comment
Anders2303 Oct 28, 2025
9243db6
Merge branch 'master' into bugfix/2D-viewer-moves-to-origin
Anders2303 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions typescript/packages/subsurface-viewer/src/components/Map.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ const Map: React.FC<MapProps> = ({
radius: pickingRadius,
});

pickInfos.forEach((itemPick) => {
const extendedPickInfos = pickInfos.map((itemPick) => {
const extItemPick = makeExtendedPickingInfo(itemPick);
// Z value should not take into account the Z scale factor.
viewController.unscaledTarget(
Expand All @@ -663,8 +663,10 @@ const Map: React.FC<MapProps> = ({
}
});
}

return extItemPick;
});
return pickInfos;
return extendedPickInfos;
},
[pickingDepth, pickingRadius, viewController]
);
Expand All @@ -687,12 +689,8 @@ const Map: React.FC<MapProps> = ({
event.tapCount == 2 // Note. Detect double click.
) {
// Left button click identifies new camera rotation anchor.
if (infos.length >= 1) {
if (infos[0].coordinate) {
viewController.setScaledTarget(
infos[0].scaledCoordinate
);
}
if (infos.length >= 1 && infos[0].coordinate) {
viewController.setScaledTarget(infos[0].scaledCoordinate);
}
}

Expand Down Expand Up @@ -1195,6 +1193,10 @@ class ViewController {
* @param scaledTarget scaled 3D point.
*/
public setScaledTarget(scaledTarget: Point2D | Point3D | undefined): void {
if (!scaledTarget) {
return console.warn("Undefined scale-target! Skipping...");
}

const vsKey = Object.keys(this.result_.deckglViewStates).at(0);
if (vsKey) {
// deep clone to notify change (memo checks object address)
Expand Down